From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH RT v2] x86/mce: Defer mce wakeups to threads for PREEMPT_RT Date: Fri, 26 Apr 2013 10:41:37 +0200 Message-ID: <20130426084137.GC20927@linutronix.de> References: <1365705214.9609.58.camel@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: LKML , RT , Thomas Gleixner , Clark Williams , John Kacur , Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , Ingo Molnar , "H. Peter Anvin" To: Steven Rostedt Return-path: Content-Disposition: inline In-Reply-To: <1365705214.9609.58.camel@gandalf.local.home> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-rt-users.vger.kernel.org * Steven Rostedt | 2013-04-11 14:33:34 [-0400]: >As wait queue locks are notorious for long hold times, we can not >convert them to raw_spin_locks without causing issues with -rt. But >Thomas has created a "simple-wait" structure that uses raw spin locks >which may have been a good fit. > >Unfortunately, wait queues are not the only issue, as the mce_notify_irq >also does a schedule_work(), which grabs the workqueue spin locks that >have the exact same issue. mce_notify_irq() can use simple_waitqueue, no? The other issue is that mce_report_event() is scheduling a per-cpu workqueue (mce_schedule_work) in case of a memory fault. This has the same issue. Sebastian