From: Steven Rostedt <rostedt@goodmis.org>
To: Mario Kleiner <mario.kleiner@tuebingen.mpg.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Peter Hurley <peter@hurleysoftware.com>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <williams@redhat.com>,
Dave Airlie <airlied@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: BUG: sleeping function called from invalid context on 3.10.10-rt7
Date: Wed, 25 Sep 2013 10:07:30 -0400 [thread overview]
Message-ID: <20130925100730.0b63628e@gandalf.local.home> (raw)
In-Reply-To: <523CC728.4040302@tuebingen.mpg.de>
Sorry for the late reply, I was at Linux Plumbers, and had a bunch of
stuff to catch up on when I returned.
On Sat, 21 Sep 2013 00:07:36 +0200
Mario Kleiner <mario.kleiner@tuebingen.mpg.de> wrote:
> Steven, would it then be acceptable to convert that "faster" lock into a
> raw_spinlock_t or is this unacceptable? If so, the preempt_disable()
> could stay, right?
If a spinlock is tight (not held for more than 2us on todays
processors), and has little contention, than I would be fine with
converting it to raw. And if that's the only lock held you could do the
preempt_disable() call.
In fact, if you want, you can leave the preempt_disable() out of
mainline, and send a patch to us that uses "preempt_disable_rt()" and
add a comment to it. In the -rt patch, preempt_disable_rt() is a nop
when PREEMPT_RT is not set, and is preempt_disable() when it is.
-- Steve
next prev parent reply other threads:[~2013-09-25 14:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 10:28 BUG: sleeping function called from invalid context on 3.10.10-rt7 Luis Claudio R. Goncalves
2013-09-11 13:26 ` Steven Rostedt
2013-09-11 15:16 ` Peter Hurley
2013-09-11 15:38 ` Steven Rostedt
2013-09-11 19:31 ` Peter Hurley
2013-09-17 19:50 ` Peter Hurley
2013-09-17 20:55 ` Daniel Vetter
2013-09-18 16:52 ` Peter Hurley
2013-09-18 17:03 ` Daniel Vetter
2013-09-18 17:03 ` Ville Syrjälä
2013-09-20 22:07 ` Mario Kleiner
2013-09-23 8:38 ` [Intel-gfx] " Ville Syrjälä
2013-09-25 4:32 ` Mario Kleiner
2013-09-25 7:49 ` [Intel-gfx] " Ville Syrjälä
2013-09-25 14:18 ` Steven Rostedt
2013-09-26 16:43 ` Mario Kleiner
2013-09-25 13:52 ` Steven Rostedt
2013-09-25 14:13 ` Steven Rostedt
2013-09-26 16:16 ` Mario Kleiner
2013-10-11 10:18 ` Sebastian Andrzej Siewior
2013-10-11 12:37 ` Steven Rostedt
2013-10-11 13:30 ` Sebastian Andrzej Siewior
2013-10-11 13:49 ` Mario Kleiner
2013-10-11 14:38 ` Steven Rostedt
2013-09-25 14:07 ` Steven Rostedt [this message]
2013-09-11 18:29 ` Mario Kleiner
2013-09-11 18:35 ` Steven Rostedt
2013-09-11 19:07 ` Mario Kleiner
2013-09-11 19:19 ` Steven Rostedt
2013-09-11 20:23 ` Mario Kleiner
2013-10-11 14:19 ` Sebastian Andrzej Siewior
2013-10-11 14:45 ` Luis Claudio R. Goncalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925100730.0b63628e@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=airlied@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mario.kleiner@tuebingen.mpg.de \
--cc=peter@hurleysoftware.com \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).