From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Yang Shi <yang.shi@windriver.com>
Cc: linux-rt-users@vger.kernel.org, paul.gortmaker@windriver.com
Subject: Re: [PATCH 1/2] rt: Don't call schedule_work_on in preemption disabled context
Date: Fri, 4 Oct 2013 17:46:16 +0200 [thread overview]
Message-ID: <20131004154616.GJ19953@linutronix.de> (raw)
In-Reply-To: <1379365759-5743-2-git-send-email-yang.shi@windriver.com>
* Yang Shi | 2013-09-16 14:09:18 [-0700]:
>---
> mm/memcontrol.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>index 82a187a..9f7cc0f 100644
>--- a/mm/memcontrol.c
>+++ b/mm/memcontrol.c
>@@ -2453,8 +2453,11 @@ static void drain_all_stock(struct mem_cgroup *root_memcg, bool sync)
> if (!test_and_set_bit(FLUSHING_CACHED_CHARGE, &stock->flags)) {
> if (cpu == curcpu)
> drain_local_stock(&stock->work);
>- else
>+ else {
>+ preempt_enable();
> schedule_work_on(cpu, &stock->work);
>+ preempt_disable();
>+ }
> }
What ensures that you don't switch CPUs between preempt_enable() &
preempt_disable() and is curcpu != smp_processor_id() ?
What about removing the get_cpu() & put_cpu() calls (and the shortcut)?
> }
> put_cpu();
Sebastian
next prev parent reply other threads:[~2013-10-04 15:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 21:09 Fix two sleeping function called in atomic context bug Yang Shi
2013-09-16 21:09 ` [PATCH 1/2] rt: Don't call schedule_work_on in preemption disabled context Yang Shi
2013-10-04 15:46 ` Sebastian Andrzej Siewior [this message]
2013-10-04 16:36 ` Yang Shi
2013-10-04 17:10 ` Sebastian Andrzej Siewior
2013-10-04 17:49 ` Yang Shi
2013-10-04 17:56 ` Sebastian Andrzej Siewior
2013-09-16 21:09 ` [PATCH 2/2] rt: Move schedule_work call to helper thread Yang Shi
2013-10-04 17:11 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131004154616.GJ19953@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=yang.shi@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).