From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Tiejun Chen <tiejun.chen@windriver.com>
Cc: tglx@linutronix.de, stable-rt@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [v1][PATCH] cpu_down: move migrate_enable() back
Date: Sat, 16 Nov 2013 14:05:00 +0100 [thread overview]
Message-ID: <20131116130500.GB11518@linutronix.de> (raw)
In-Reply-To: <1383789967-5885-1-git-send-email-tiejun.chen@windriver.com>
* Tiejun Chen | 2013-11-07 10:06:07 [+0800]:
>Commit 08c1ab68, "hotplug-use-migrate-disable.patch", intends to
>use migrate_enable()/migrate_disable() to replace that combination
>of preempt_enable() and preempt_disable(), but actually in
>!CONFIG_PREEMPT_RT_FULL case, migrate_enable()/migrate_disable()
>are still equal to preempt_enable()/preempt_disable(). So that
>followed cpu_hotplug_begin()/cpu_unplug_begin(cpu) would go schedule()
>to trigger schedule_debug() like this:
>
>_cpu_down()
> |
> + migrate_disable() = preempt_disable()
> |
> + cpu_hotplug_begin() or cpu_unplug_begin()
> |
> + schedule()
> |
> + __schedule()
> |
> + preempt_disable();
> |
> + __schedule_bug() is true!
>
>So we should move migrate_enable() as the original scheme.
>
>Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
applied.
Sebastian
prev parent reply other threads:[~2013-11-16 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 2:06 [v1][PATCH] cpu_down: move migrate_enable() back Tiejun Chen
2013-11-11 15:32 ` Paul Gortmaker
2013-11-15 9:31 ` Sebastian Andrzej Siewior
2013-11-16 13:05 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131116130500.GB11518@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=stable-rt@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tiejun.chen@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).