From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Kacur <jkacur@redhat.com>, Wolfram Sang <wsa@the-dreams.de>,
Anatolij Gustschin <agust@denx.de>
Subject: [PATCH RT 2/7] Kind of revert "powerpc: 52xx: provide a default in mpc52xx_irqhost_map()"
Date: Thu, 21 Nov 2013 11:59:50 -0500 [thread overview]
Message-ID: <20131121170116.730958413@goodmis.org> (raw)
In-Reply-To: 20131121165948.354971355@goodmis.org
[-- Attachment #1: 0002-Kind-of-revert-powerpc-52xx-provide-a-default-in-mpc.patch --]
[-- Type: text/plain, Size: 1762 bytes --]
3.8.13.13-rt25-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Wolfram Sang <wsa@the-dreams.de>
This more or less reverts commit 6391f697d4892a6f233501beea553e13f7745a23.
Instead of adding an unneeded 'default', mark the variable to prevent
the false positive 'uninitialized var'. The other change (fixing the
printout) needs revert, too. We want to know WHICH critical irq failed,
not which level it had.
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Cc: stable-rt@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Anatolij Gustschin <agust@denx.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
arch/powerpc/platforms/52xx/mpc52xx_pic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pic.c b/arch/powerpc/platforms/52xx/mpc52xx_pic.c
index b69221b..2898b73 100644
--- a/arch/powerpc/platforms/52xx/mpc52xx_pic.c
+++ b/arch/powerpc/platforms/52xx/mpc52xx_pic.c
@@ -340,7 +340,7 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq,
{
int l1irq;
int l2irq;
- struct irq_chip *irqchip;
+ struct irq_chip *uninitialized_var(irqchip);
void *hndlr;
int type;
u32 reg;
@@ -373,9 +373,8 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq,
case MPC52xx_IRQ_L1_PERP: irqchip = &mpc52xx_periph_irqchip; break;
case MPC52xx_IRQ_L1_SDMA: irqchip = &mpc52xx_sdma_irqchip; break;
case MPC52xx_IRQ_L1_CRIT:
- default:
pr_warn("%s: Critical IRQ #%d is unsupported! Nopping it.\n",
- __func__, l1irq);
+ __func__, l2irq);
irq_set_chip(virq, &no_irq_chip);
return 0;
}
--
1.8.4.rc3
next prev parent reply other threads:[~2013-11-21 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 16:59 [PATCH RT 0/7] Linux 3.8.13.13-rt25-rc1 Steven Rostedt
2013-11-21 16:59 ` [PATCH RT 1/7] genirq: Set the irq thread policy without checking CAP_SYS_NICE Steven Rostedt
2013-11-21 16:59 ` Steven Rostedt [this message]
2013-11-21 16:59 ` [PATCH RT 3/7] hwlat-detector: Dont ignore threshold module parameter Steven Rostedt
2013-11-21 16:59 ` [PATCH RT 4/7] mm/slub: do not rely on slab_cached passed to free_delayed() Steven Rostedt
2013-11-21 16:59 ` [PATCH RT 5/7] mm/memcontrol: Dont call schedule_work_on in preemption disabled context Steven Rostedt
2013-11-21 16:59 ` [PATCH RT 6/7] drm: remove preempt_disable() from drm_calc_vbltimestamp_from_scanoutpos() Steven Rostedt
2013-11-21 16:59 ` [PATCH RT 7/7] Linux 3.8.13.13-rt25-rc1 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121170116.730958413@goodmis.org \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=agust@denx.de \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).