linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Mc Guire <der.herr@hofr.at>
To: linux-rt-users@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH] consolidate spin_lock/unlock waiting with spin_unlock_wait
Date: Mon, 2 Dec 2013 05:41:26 +0100	[thread overview]
Message-ID: <20131202044126.GA18399@opentech.at> (raw)

>From 19ac7e10b38947dbd8d731a13243fb28490f5ab4 Mon Sep 17 00:00:00 2001
From: Nicholas Mc Guire <der.herr@hofr.at>
Date: Sun, 1 Dec 2013 23:03:52 -0500
Subject: [PATCH] consolidate spin_lock/unlock waiting with spin_unlock_wait

 since:
 commit c2f21ce2e31286a0a32f8da0a7856e9ca1122ef3
 Author: Thomas Gleixner <tglx@linutronix.de>
 Date:   Wed Dec 2 20:02:59 2009 +0100

 include/linux/spinlock.h includes spin_unlock_wait() to wait for a concurrent
 holder of a lock. this patch just moves over to that API. spin_unlock_wait
 covers both raw_spinlock_t and spinlock_t so it should be safe here as well.
 the added rt-variant of read_seqbegin in include/linux/seqlock.h that is being
 modified, was introduced by patch:
   seqlock-prevent-rt-starvation.patch

 patch is on top of 3.12.1-rt4

 behavior should be unchanged.


Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
 include/linux/seqlock.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index 142c0f7..019a936 100644
--- a/include/linux/seqlock.h
+++ b/include/linux/seqlock.h
@@ -236,8 +236,7 @@ repeat:
 		 * Take the lock and let the writer proceed (i.e. evtl
 		 * boost it), otherwise we could loop here forever.
 		 */
-		spin_lock(&sl->lock);
-		spin_unlock(&sl->lock);
+		spin_unlock_wait(&sl->lock);
 		goto repeat;
 	}
 	return ret;
-- 
1.7.2.5


             reply	other threads:[~2013-12-02  4:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02  4:41 Nicholas Mc Guire [this message]
2013-12-15 13:44 ` [PATCH] consolidate spin_lock/unlock waiting with spin_unlock_wait Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131202044126.GA18399@opentech.at \
    --to=der.herr@hofr.at \
    --cc=bigeasy@linutronix.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).