From: Nicholas Mc Guire <der.herr@hofr.at>
To: linux-rt-users@vger.kernel.org
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andreas Platschek <platschek@ict.tuwien.ac.at>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH 1/3] make migrate disable/enable conditioned on softirq_nestcnt transition
Date: Fri, 6 Dec 2013 00:42:22 +0100 [thread overview]
Message-ID: <20131205234222.GE15603@opentech.at> (raw)
This patch removes the recursive calls to migrate_disable/enable in
local_bh_disable/enable
the softirq-local-lock.patch introduces local_bh_disable/enable wich
decrements/increments the current->softirq_nestcnt and disable/enables
migration as well. as softirq_nestcnt (include/linux/sched.h conditioned
on CONFIG_PREEMPT_RT_BASE) already is tracking the nesting level of the
recursive calls to local_bh_disable/enable (all in kernel/softirq.c) - no
need to do it twice.
migrate_disable/enable thus can be conditionsed on softirq_nestcnt making
a transition from 0-1 to disable migration and 1-0 to re-enable it.
patch on top of 3.12.1-rt4
No change of functional behavior, this does noticably reduce the observed
nesting level of migrate_disable/enable
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
kernel/softirq.c | 14 ++++++++------
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 9a7268f..16ebbd9 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -569,8 +569,8 @@ static void do_current_softirqs(int need_rcu_bh_qs)
void local_bh_disable(void)
{
- migrate_disable();
- current->softirq_nestcnt++;
+ if (++current->softirq_nestcnt == 1)
+ migrate_disable();
}
EXPORT_SYMBOL(local_bh_disable);
@@ -584,8 +584,8 @@ void local_bh_enable(void)
do_current_softirqs(1);
local_irq_enable();
- current->softirq_nestcnt--;
- migrate_enable();
+ if (--current->softirq_nestcnt == 0)
+ migrate_enable();
}
EXPORT_SYMBOL(local_bh_enable);
@@ -597,8 +597,10 @@ EXPORT_SYMBOL(local_bh_enable_ip);
void _local_bh_enable(void)
{
- current->softirq_nestcnt--;
- migrate_enable();
+ if (WARN_ON(current->softirq_nestcnt == 0))
+ return;
+ if (--current->softirq_nestcnt == 0)
+ migrate_enable();
}
EXPORT_SYMBOL(_local_bh_enable);
--
1.7.2.5
next reply other threads:[~2013-12-05 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 23:42 Nicholas Mc Guire [this message]
2013-12-06 0:45 ` [PATCH 1/3] make migrate disable/enable conditioned on softirq_nestcnt transition Steven Rostedt
2013-12-15 14:46 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205234222.GE15603@opentech.at \
--to=der.herr@hofr.at \
--cc=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=platschek@ict.tuwien.ac.at \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).