From: David Miller <davem@davemloft.net>
To: gregkh@linuxfoundation.org
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, nicolas.dichtel@6wind.com,
williams@redhat.com, linux-rt-users@vger.kernel.org,
lclaudio@uudg.org
Subject: Re: [BUG] stable v3.10.16+ introduced by "ip6tnl: allow to use rtnl ops on fb tunnel"
Date: Wed, 11 Dec 2013 16:53:31 -0500 (EST) [thread overview]
Message-ID: <20131211.165331.495095016561766264.davem@davemloft.net> (raw)
In-Reply-To: <20131209002531.GB14382@kroah.com>
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: Sun, 8 Dec 2013 16:25:31 -0800
> On Wed, Nov 13, 2013 at 09:14:30PM -0500, Steven Rostedt wrote:
>> +++ b/net/ipv6/ip6_tunnel.c
>> @@ -1731,8 +1731,6 @@ static void __net_exit ip6_tnl_destroy_tunnels(struct ip
>> }
>> }
>>
>> - t = rtnl_dereference(ip6n->tnls_wc[0]);
>> - unregister_netdevice_queue(t->dev, &list);
>> unregister_netdevice_many(&list);
>> }
>>
>>
>> Which, when applied to 3.10.18, fixes the bug. Was there a reason that
>> this part of the commit wasn't backported? or was this just an oversight?
>
> It looks like it was left out to me as well.
>
> David, any objection to me making this fixup in the 3.10-stable tree?
The original patch submitted told me to leave this part of the patch
out of the backport, explaining that it wasn't necessary in older
kernels.
Can someone please sort this out?
Nicolas please provide some guidance here, thanks.
next prev parent reply other threads:[~2013-12-11 21:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 2:14 [BUG] stable v3.10.16+ introduced by "ip6tnl: allow to use rtnl ops on fb tunnel" Steven Rostedt
2013-11-14 14:47 ` [PATCH net] ip6tnl: fix use after free of fb_tnl_dev Nicolas Dichtel
2013-11-14 15:40 ` Willem de Bruijn
2013-11-14 22:05 ` David Miller
2013-11-14 22:18 ` Steven Rostedt
2013-12-09 0:25 ` [BUG] stable v3.10.16+ introduced by "ip6tnl: allow to use rtnl ops on fb tunnel" Greg Kroah-Hartman
2013-12-09 14:48 ` Steven Rostedt
2013-12-09 14:54 ` Steven Rostedt
2013-12-11 21:53 ` David Miller [this message]
2013-12-12 9:53 ` Nicolas Dichtel
2013-12-12 20:35 ` David Miller
2013-12-13 9:06 ` [PATCH linux-3.10.y] ip6tnl: fix use after free of fb_tnl_dev Nicolas Dichtel
2013-12-17 19:40 ` David Miller
2013-12-17 19:54 ` Greg KH
2013-12-19 10:07 ` Luis Henriques
2013-12-19 10:23 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211.165331.495095016561766264.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).