From: Clark Williams <williams@redhat.com>
To: Ciprian Barbu <ciprian.barbu@linaro.org>
Cc: RT <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linaro Networking <linaro-networking@linaro.org>
Subject: Re: [PATCH] rt-tests: hackbench: fix for uninitialized start time
Date: Thu, 12 Dec 2013 09:14:22 -0600 [thread overview]
Message-ID: <20131212091422.3b909d99@sluggy> (raw)
In-Reply-To: <52A9CC77.20904@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Thu, 12 Dec 2013 16:47:19 +0200
Ciprian Barbu <ciprian.barbu@linaro.org> wrote:
> Hello,
>
> While playing around with hackbench I discovered that I would sometimes
> get an enormous time reported, even if the run time would be less than a
> second or so. The problem was that the struct timeval start was not
> initialized until after all children have been created. But if the
> program receives a signal before this is done, the start time is left
> uninitialized.
>
> I propose that in such situations an error message be displayed, like
> the following patch does.
>
> Please let me know if this is acceptable.
>
> Regards,
> /Ciprian
Looks good to me. I've pulled it in for the next release.
Clark
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-12-12 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 14:47 [PATCH] rt-tests: hackbench: fix for uninitialized start time Ciprian Barbu
2013-12-12 15:14 ` Clark Williams [this message]
2013-12-12 20:29 ` 3.12.5 CRASH/FREEZE Pavel Vasilyev
2013-12-20 14:10 ` Sebastian Andrzej Siewior
2013-12-20 14:57 ` Pavel Vasilyev
2013-12-20 15:05 ` Sebastian Andrzej Siewior
2013-12-22 22:19 ` Pavel Vasilyev
2013-12-22 22:33 ` Pavel Vasilyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212091422.3b909d99@sluggy \
--to=williams@redhat.com \
--cc=ciprian.barbu@linaro.org \
--cc=linaro-networking@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).