From: Nicholas Mc Guire <der.herr@hofr.at>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-rt-users@vger.kernel.org,
Andreas Platschek <platschek@ict.tuwien.ac.at>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Carsten Emde <carsten.emde@osadl.org>
Subject: Re: [PATCH 2/3] read_lock migrate_disable pushdown to rt_read_lock
Date: Sat, 25 Jan 2014 09:29:21 +0100 [thread overview]
Message-ID: <20140125082921.GA3831@opentech.at> (raw)
In-Reply-To: <20140124124216.GB10264@linutronix.de>
On Fri, 24 Jan 2014, Sebastian Andrzej Siewior wrote:
> * Sebastian Andrzej Siewior | 2013-12-15 16:15:11 [+0100]:
>
> >* Steven Rostedt | 2013-12-06 10:25:32 [-0500]:
> >
> >>
> >>Let me analyze the original code first. I'll poke peterz and tglx too
> >>to make sure this modification is OK.
> >
> >I took 1/3. I postpone the remaining two until I hear something from
> >you.
>
> Any news?
>
Carsten Emde added the two patches
0001-write_lock-migrate_disable-pushdown-to-rt_write_lock.patch
0002-read_lock-migrate_disable-pushdown-to-rt_read_lock.patch
to the -rt9 test on one of his ARM boards (i.MX6 Sabre automation board)
in the OSADL QA-Farm (rack #9/slot #8)
<snip Carsten Emde>
No complaints so far after adding your patches.
If you would like to follow up:
- Profile: https://www.osadl.org/?id=1822
- Patches: https://www.osadl.org/?id=1822#patches
- Latency plot: https://www.osadl.org/?id=1823
- Munin:
https://www.osadl.org/munin/osadl.org/rack9slot8.osadl.org/index.html
<snip>
so it atleast seems to be passing basic testing.
I have an AMD Phenom X4 and Intel i3 running -rt9 with those two patches
applied running stable now for 2 days under alternating load/idle conditions
as well. Unfortunately no further feedback up to now.
Given that its a low-level locking issue I guess that more testing is of little
help and code-reviews would be essential. Notably if any cases could exist
where the order of preempt_disable/lock critical-section unlock/preempt_enable
actually does natter.
thx!
hofrat
prev parent reply other threads:[~2014-01-25 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 23:44 [PATCH 2/3] read_lock migrate_disable pushdown to rt_read_lock Nicholas Mc Guire
2013-12-06 2:19 ` Steven Rostedt
2013-12-06 2:33 ` Nicholas Mc Guire
2013-12-06 15:25 ` Steven Rostedt
2013-12-15 15:15 ` Sebastian Andrzej Siewior
2014-01-24 12:42 ` Sebastian Andrzej Siewior
2014-01-25 8:29 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140125082921.GA3831@opentech.at \
--to=der.herr@hofr.at \
--cc=bigeasy@linutronix.de \
--cc=carsten.emde@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=platschek@ict.tuwien.ac.at \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).