linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: allen.pais@oracle.com
Cc: tkhai@yandex.ru, linux-rt-users@vger.kernel.org,
	sparclinux@vger.kernel.org, bigeasy@linutronix.de
Subject: Re: [PATCH 3/4] sparc64: convert spinlock_t to raw_spinlock_t in mmu_context_t
Date: Tue, 04 Mar 2014 23:52:07 -0500 (EST)	[thread overview]
Message-ID: <20140304.235207.1428291234888893240.davem@davemloft.net> (raw)
In-Reply-To: <5316A970.1000808@oracle.com>

From: Allen Pais <allen.pais@oracle.com>
Date: Wed, 05 Mar 2014 10:04:56 +0530

> On Wednesday 05 March 2014 01:31 AM, David Miller wrote:
>> From: Allen Pais <allen.pais@oracle.com>
>> Date: Wed, 19 Feb 2014 09:23:46 +0530
>> 
>>>  I realized locking in tsb is very tricky. My attempts to try and get hackbench run
>>> without causing a stall failed. So here's what I tried to fix it, am not sure if it's
>>> an appropriate fix, I would love to get comments. I have tested this fix for over 24 hours
>>> with hackbench and dd, the system did not stall :)
>> 
>> If using a local lock fixes your problem, it just means we're being
>> preempted during flush_tsb_user() which is absolutely not allowed.
> 
> David, Its my bad, I realized my mistake of using local locks.
> Am still looking into the tsb flush code. It's left me sleepless. :)

So let's do a simple test, in flush_tlb_user() assert to make sure we
cannot be preempted by the -rt kernel.

  reply	other threads:[~2014-03-05  4:52 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1388980510-10190-1-git-send-email-allen.pais@oracle.com>
2014-02-05  3:31 ` [PATCH 0/4] PREEMPT_RT support for sparc64 Allen Pais
2014-02-05  8:28   ` Sebastian Andrzej Siewior
2014-02-05 10:38     ` Allen Pais
2014-02-05 10:43       ` Sebastian Andrzej Siewior
2014-02-05 10:51         ` Allen Pais
     [not found] ` <1388980510-10190-4-git-send-email-allen.pais@oracle.com>
     [not found]   ` <341392153219@web17g.yandex.ru>
2014-02-12  7:48     ` [PATCH 3/4] sparc64: convert spinlock_t to raw_spinlock_t in mmu_context_t Allen Pais
2014-02-12  8:33       ` Kirill Tkhai
2014-02-12 11:28         ` Allen Pais
2014-02-12 11:43           ` Kirill Tkhai
2014-02-12 12:14             ` Allen Pais
2014-02-12 12:45               ` Kirill Tkhai
2014-02-12 13:05                 ` Allen Pais
2014-02-19  3:53                 ` Allen Pais
2014-02-19  8:09                   ` Kirill Tkhai
2014-02-19  8:12                     ` Allen Pais
2014-02-19  8:57                       ` Kirill Tkhai
2014-02-19  8:59                         ` Allen Pais
2014-02-19  9:13                         ` Allen Pais
2014-02-19  9:25                           ` Kirill Tkhai
2014-02-19  9:31                             ` Allen Pais
2014-02-26  7:51                             ` Allen Pais
2014-02-28 14:51                               ` Kirill Tkhai
2014-03-04 19:10                                 ` David Miller
2014-03-04 20:28                                   ` David Miller
2014-03-05  4:30                                     ` Allen Pais
2014-03-06 21:36                                       ` David Miller
2014-03-07 14:05                                         ` Sebastian Andrzej Siewior
2014-03-04 20:39                                   ` Kirill Tkhai
2014-03-07 13:41                                   ` Sebastian Andrzej Siewior
2014-03-04 20:03                             ` David Miller
2014-03-04 21:26                               ` Kirill Tkhai
2014-03-04 20:01                   ` David Miller
2014-03-05  4:34                     ` Allen Pais
2014-03-05  4:52                       ` David Miller [this message]
2014-03-04 19:59             ` David Miller
2014-03-04 19:55         ` David Miller
2014-03-04 20:44           ` Kirill Tkhai
2014-03-07 14:29           ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140304.235207.1428291234888893240.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=allen.pais@oracle.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tkhai@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).