From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU>,
Ben Skeggs <bskeggs@redhat.com>,
Peter Hurley <peter@hurleysoftware.com>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Thomas Gleixner <tglx@linutronix.de>,
rostedt@goodmis.org, John Kacur <jkacur@redhat.com>
Subject: Re: nouveau crash due to missing channel (WAS: Re: [ANNOUNCE] 3.12.12-rt19)
Date: Fri, 7 Mar 2014 12:53:57 +0100 [thread overview]
Message-ID: <20140307115357.GB8637@linutronix.de> (raw)
In-Reply-To: <5319AF2D.2060004@canonical.com>
* Maarten Lankhorst | 2014-03-07 12:36:13 [+0100]:
>>I can't find any kind of locking so my question is what ensures that chan is
>>not set to NULL between nouveau_fence_done() and
>>nouveau_fence_wait_uevent()? There are just a few opcodes in between but
>>nothing that pauses nouveau_fence_signal().
>Absolutely nothing. :-) Worse still, there's no guarantee that channel isn't freed, but hopefully that is less likely to be an issue.
Okay, so I hit the correct spot. What do we do here? Do you want the
patch I posted without the WARN_ON() or do you prefer to fix this in an
other way?
>~Maarten
Sebastian
prev parent reply other threads:[~2014-03-07 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 18:47 [ANNOUNCE] 3.12.12-rt19 Sebastian Andrzej Siewior
2014-02-23 19:13 ` Pavel Vasilyev
2014-02-23 19:29 ` Pavel Vasilyev
2014-02-23 21:13 ` Thomas Gleixner
2014-02-23 22:55 ` Pavel Vasilyev
2014-02-27 3:07 ` Steven Rostedt
2014-03-02 1:48 ` Fernando Lopez-Lezcano
2014-03-07 11:18 ` nouveau crash due to missing channel (WAS: Re: [ANNOUNCE] 3.12.12-rt19) Sebastian Andrzej Siewior
2014-03-07 11:36 ` Maarten Lankhorst
2014-03-07 11:53 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307115357.GB8637@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=nando@ccrma.Stanford.EDU \
--cc=peter@hurleysoftware.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).