From: Steven Rostedt <rostedt@goodmis.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
<linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
<stable-rt@vger.kernel.org>
Subject: Re: [PATCH RT 2/4] net: gianfar: do not try to cleanup TX packets if they are not done
Date: Tue, 29 Apr 2014 10:25:05 -0400 [thread overview]
Message-ID: <20140429102505.1d52f93c@gandalf.local.home> (raw)
In-Reply-To: <535FB453.2060100@windriver.com>
On Tue, 29 Apr 2014 10:16:51 -0400
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> Sanity boot tested the 3.10 rc1 on a sbc8548 (UP PPC with gianfar), with
> the one-liner added as follows:
>
> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
> index 8aecc1d81395..b87a8c919c3e 100644
> --- a/drivers/net/ethernet/freescale/gianfar.c
> +++ b/drivers/net/ethernet/freescale/gianfar.c
> @@ -2574,6 +2574,7 @@ static int gfar_clean_tx_ring(struct gfar_priv_tx_q *tx_queue)
> tx_queue->dirty_tx = bdp;
>
> netdev_tx_completed_queue(txq, howmany, bytes_sent);
> + return howmany;
That's the change I added to 3.10-rc2. I'll post it soon if you want to
test it.
-- Steve
> }
>
> static void gfar_schedule_cleanup(struct gfar_priv_grp *gfargrp)
next prev parent reply other threads:[~2014-04-29 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 14:31 [PATCH RT 0/4] Linux 3.10.37-rt38-rc1 Steven Rostedt
2014-04-27 14:31 ` [PATCH RT 1/4] net: gianfar: do not disable interrupts Steven Rostedt
2014-04-27 14:31 ` [PATCH RT 2/4] net: gianfar: do not try to cleanup TX packets if they are not done Steven Rostedt
2014-04-28 6:37 ` Sebastian Andrzej Siewior
2014-04-29 14:16 ` Paul Gortmaker
2014-04-29 14:25 ` Steven Rostedt [this message]
2014-04-27 14:31 ` [PATCH RT 3/4] rcu: make RCU_BOOST default on RT Steven Rostedt
2014-04-27 14:31 ` [PATCH RT 4/4] Linux 3.10.37-rt38-rc1 Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2014-04-29 14:30 [PATCH RT 0/4] Linux 3.10.37-rt38-rc2 Steven Rostedt
2014-04-29 14:31 ` [PATCH RT 2/4] net: gianfar: do not try to cleanup TX packets if they are not done Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429102505.1d52f93c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=stable-rt@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).