From: Steven Rostedt <rostedt@goodmis.org>
To: Corey Minyard <cminyard@mvista.com>
Cc: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH RT 0/3] Linux 3.10.47-rt50-rc1
Date: Mon, 14 Jul 2014 20:53:33 -0400 [thread overview]
Message-ID: <20140714205333.6d28ed1f@gandalf.local.home> (raw)
In-Reply-To: <53C4714C.8000103@mvista.com>
On Mon, 14 Jul 2014 19:09:48 -0500
Corey Minyard <cminyard@mvista.com> wrote:
> Can we get:
>
> tracing-use-migrate_disable-to-prevent-beeing-pushed.patch
Sure except that patch is buggy:
- preempt_disable();
+ migrate_disable();
/* The update must run on the CPU that is being updated. */
if (cpu_id == smp_processor_id() || !cpu_online(cpu_id))
rb_update_pages(cpu_buffer);
else {
- /*
- * Can not disable preemption for schedule_work_on()
- * on PREEMPT_RT.
- */
- preempt_enable();
schedule_work_on(cpu_id,
&cpu_buffer->update_pages_work);
wait_for_completion(&cpu_buffer->update_done);
- preempt_disable();
}
- preempt_enable();
+ migrate_enable();
migrate_disable() on non-PREEMPT_RT is preempt_disable(). You can't
call wait_or_completion with preemption disabled.
When that gets fixed in mainline -rt, I'll add it to the stable
branches too.
-- Steve
>
> into 3.10, also?
>
next prev parent reply other threads:[~2014-07-15 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 20:04 [PATCH RT 0/3] Linux 3.10.47-rt50-rc1 Steven Rostedt
2014-07-14 20:04 ` [PATCH RT 1/3] sched: Do not clear PF_NO_SETAFFINITY flag in select_fallback_rq() Steven Rostedt
2014-07-14 20:04 ` [PATCH RT 2/3] workqueue: Prevent deadlock/stall on RT Steven Rostedt
2014-07-14 20:04 ` [PATCH RT 3/3] Linux 3.10.47-rt50-rc1 Steven Rostedt
2014-07-15 0:09 ` [PATCH RT 0/3] " Corey Minyard
2014-07-15 0:53 ` Steven Rostedt [this message]
2014-07-16 14:31 ` Corey Minyard
2014-07-16 15:22 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140714205333.6d28ed1f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=cminyard@mvista.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).