linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Clark Williams <clark.williams@gmail.com>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: chase.qi@linaro.org, linux-rt-users@vger.kernel.org,
	milosz.wasilewski@linaro.org, naresh.kamboju@linaro.org,
	anders.roxell@linaro.org, mike.holmes@linaro.org,
	John Kacur <jkacur@gmail.com>
Subject: Re: [PATCH] pip_stress: increase usleep for ARM devices
Date: Wed, 10 Dec 2014 15:16:50 -0600	[thread overview]
Message-ID: <20141210151650.1995581e@sluggy> (raw)
In-Reply-To: <54885564.2050904@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 1757 bytes --]

On Wed, 10 Dec 2014 09:15:00 -0500
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:

> On 12/10/2014 03:25 AM, chase.qi@linaro.org wrote:
> > From: Chase Qi <chase.qi@linaro.org>
> >
> > Hello,
> >
> > pip_stress works out of the box on my x86 based laptop, but
> > doesn't work on ARM devices, returned 'no inversion incurred'.
> > Follow the comment to increase usleep value, 2500 worked for
> > pandaboard and 3000 worked for Beaglebone Black board.
> >
> > I propose that increase the usleep value to 3500 from upstream,
> > so that we can use pip_stress right out of the box.
> >
> > Please let me know if this is acceptable.
> 
> I think they should have modified main() to accept the lock time as a parameter
> instead of simply adding some instructions in the comments
> 
>  * to show that it works. If you are having difficulty triggering an inversion,
>  * merely increase the time that the low priority process sleeps while
>  * holding the lock. (usleep);
>  * Also note that you have to run as a user with permission to change
>  * scheduling priorities.
>  */
> 
> what I would do is actually
> 1. modify main to accept lock_time
> 2. send the patch to the rt-tests team
> 
> 
>

I wish we didn't have to deal with timers here. I used barriers when I
wrote pi_stress.c and obviously we don't have that luxury with
pip_stress.c. I guess the best thing we can do right now is add a
parameter to change the default timer value for pip_stress and see if
someone comes up with a brilliant state-machine solution that will work
between processes :).

John and I are about to start a sweep through the tests and will
probably come out with a new rt-tests around the first of the year. 

Clark

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-12-10 21:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10  8:25 [PATCH] pip_stress: increase usleep for ARM devices chase.qi
2014-12-10 10:00 ` Pavel Vasilyev
2014-12-10 14:15 ` Jorge Ramirez-Ortiz
2014-12-10 21:16   ` Clark Williams [this message]
2015-01-15 18:44     ` Clark Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141210151650.1995581e@sluggy \
    --to=clark.williams@gmail.com \
    --cc=anders.roxell@linaro.org \
    --cc=chase.qi@linaro.org \
    --cc=jkacur@gmail.com \
    --cc=jorge.ramirez-ortiz@linaro.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mike.holmes@linaro.org \
    --cc=milosz.wasilewski@linaro.org \
    --cc=naresh.kamboju@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).