Re: [PATCH] rt-migrate-test: exit early if nr_runs is non-positive

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

* Boris Egorov | 2014-11-27 16:20:34 [+0600]:

>Program will crash if nr_runs is 0 due to dividing by it in
>print_results(). Let's exit early instead.
>
>Fixes: http://bugs.debian.org/716237

Has this been dealt with? I can't see this applied. I would prefer
doing the value check in parse_options() itself. And looking at it, it
seems that run_interval is interval ignored. Or is there macro magic
invovled?

>Signed-off-by: Boris Egorov <egorov@linux.com>
>---
> src/rt-migrate-test/rt-migrate-test.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/src/rt-migrate-test/rt-migrate-test.c
>b/src/rt-migrate-test/rt-migrate-test.c
>index e3c7a09..876a122 100644
>--- a/src/rt-migrate-test/rt-migrate-test.c
>+++ b/src/rt-migrate-test/rt-migrate-test.c
>@@ -465,6 +465,11 @@ int main (int argc, char **argv)
>  	parse_options(argc, argv);
>+	if (nr_runs <= 0) {
>+		fprintf(stderr, "Warning, --loops argument is non-positive. Exiting.\n");
>+		exit(-1);
>+	}
>+
> 	signal(SIGINT, stop_log);
>  	if (argc >= (optind + 1))
>-- 
>2.1.3

Sebastian