From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Brad Mouring <bmouring@ni.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
linux-rt-users@vger.kernel.org, T Makphaibulchoke <tmac@hp.com>,
Brad Mouring <brad.mouring@ni.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] rtmutex.c: Fix incorrect waiter check
Date: Tue, 17 Feb 2015 17:10:31 +0100 [thread overview]
Message-ID: <20150217161031.GT26177@linutronix.de> (raw)
In-Reply-To: <20150121151352.7e4ef150@gandalf.local.home>
* Steven Rostedt | 2015-01-21 15:13:52 [-0500]:
>On Wed, 14 Jan 2015 15:11:38 -0600
>"Brad Mouring" <bmouring@ni.com> wrote:
>
>> In task_blocks_on_lock, there's a null check on pi_blocked_on
>> of the task_struct. This pointer can encode the fact that the
>> task that contains the pointer is waking (preventing requeuing)
>> and therefore is non-null. Use the inline function to avoid
>> dereferencing an invalid "pointer"
>
>Yep, this looks legit. I can apply it to the series I maintain.
I added it to v3.18 with a stable tag. I don't know why this did not
pop-up earlier or if this is part of the rtmutex re-write.
>-- Steve
Sebastian
next prev parent reply other threads:[~2015-02-17 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 19:35 [PATCH] rtmutex.c: Fix incorrect waiter check Brad Mouring
2014-12-16 0:35 ` Thavatchai Makphaibulchoke
2015-01-14 21:11 ` [re: PATCH] " Brad Mouring
2015-01-14 21:11 ` [PATCH] " Brad Mouring
2015-01-21 20:13 ` Steven Rostedt
2015-02-17 16:10 ` Sebastian Andrzej Siewior [this message]
2015-08-17 10:41 ` AW: " eg Engleder Gerhard
2015-08-17 14:40 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217161031.GT26177@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bmouring@ni.com \
--cc=brad.mouring@ni.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tmac@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).