From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Qiang Huang <h.huangqiang@huawei.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
mingo@kernel.org, linux-rt-users <linux-rt-users@vger.kernel.org>,
zhangwei <jovi.zhangwei@huawei.com>,
Li Zefan <lizefan@huawei.com>,
peterz@infradead.org
Subject: Re: [RFC PATCH] tasklet: correct the comments about tasklet schedule
Date: Thu, 26 Feb 2015 15:35:55 +0100 [thread overview]
Message-ID: <20150226143555.GG12992@linutronix.de> (raw)
In-Reply-To: <536075C1.2080704@huawei.com>
* Qiang Huang | 2014-04-30 12:02:09 [+0800]:
>--- a/include/linux/interrupt.h
>+++ b/include/linux/interrupt.h
>@@ -514,9 +514,8 @@ extern void __send_remote_softirq(struct call_single_data *cp, int cpu,
> to be executed on some cpu at least once after this.
> * If the tasklet is already scheduled, but its execution is still not
> started, it will be executed only once.
>- * If this tasklet is already running on another CPU, it is rescheduled
>- for later.
This is true
>- * Schedule must not be called from the tasklet itself (a lockup occurs)
This is true
>+ * If this tasklet is already running on another CPU (or schedule is called
>+ from tasklet itself), it wound not be rescheduled.
that are two statements.
I suggest you fix the driver instead poking at the tasklet code.
> * Tasklet is strictly serialized wrt itself, but not
> wrt another tasklets. If client needs some intertask synchronization,
> he makes it with spinlocks.
Sebastian
prev parent reply other threads:[~2015-02-26 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 4:02 [RFC PATCH] tasklet: correct the comments about tasklet schedule Qiang Huang
2014-04-30 7:48 ` Qiang Huang
2015-02-26 14:35 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226143555.GG12992@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=h.huangqiang@huawei.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).