From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>,
linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally"
Date: Tue, 24 Mar 2015 19:10:34 +0100 [thread overview]
Message-ID: <20150324181034.GD1321@linutronix.de> (raw)
In-Reply-To: <20150319122611.0d002d48@gandalf.local.home>
* Steven Rostedt | 2015-03-19 12:26:11 [-0400]:
>On Thu, 19 Mar 2015 09:17:09 +0100
>Mike Galbraith <umgwanakikbuti@gmail.com> wrote:
>
>
>> (aw crap, let's go shopping)... so why is the one in timer.c ok?
>
>It's not. Sebastian, you said there were no other cases of rt_mutexes
>being taken in hard irq context. Looks like timer.c has one.
If you refer to switch_timer_base() then this one is not taken in
hard-irq context. The callchain is:
lock_timer_base() (with spin_lock_irqsave(&base->lock, *flags) which
makes it a sleeping lock or lockdep would scream)
-> switch_timer_base()
-> spin_trylock() (not in hardirq conteyt)
>So perhaps the real fix is to get that special case of ownership in
>hard interrupt context?
I'm really not sure we want to keep doing this.
>
>-- Steve
Sebastian
next prev parent reply other threads:[~2015-03-24 18:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 16:35 [PATCH RT 0/4] Linux 3.10.70-rt75-rc2 Steven Rostedt
2015-03-17 16:35 ` [PATCH RT 1/4] fs,btrfs: fix rt deadlock on extent_buffer->lock Steven Rostedt
2015-03-17 16:35 ` [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Steven Rostedt
2015-03-17 20:35 ` Steven Rostedt
2015-03-19 8:17 ` Mike Galbraith
2015-03-19 16:26 ` Steven Rostedt
2015-03-19 16:42 ` Thavatchai Makphaibulchoke
2015-03-21 18:02 ` Mike Galbraith
2015-03-23 4:42 ` Mike Galbraith
2015-03-26 2:17 ` Thavatchai Makphaibulchoke
2015-03-26 5:23 ` Mike Galbraith
2015-03-26 6:01 ` Mike Galbraith
2015-03-26 6:27 ` Mike Galbraith
2015-03-26 13:53 ` Steven Rostedt
2015-03-24 18:15 ` Sebastian Andrzej Siewior
2015-03-25 2:38 ` Mike Galbraith
2015-03-24 18:10 ` Sebastian Andrzej Siewior [this message]
2015-03-25 2:33 ` Mike Galbraith
2015-04-09 13:39 ` Sebastian Andrzej Siewior
2015-08-11 23:21 ` Jiang, Yunhong
2015-03-17 16:35 ` [PATCH RT 3/4] netpoll: guard the access to dev->npinfo with rcu_read_lock/unlock_bh() for CONFIG_PREEMPT_RT_FULL=y Steven Rostedt
2015-03-17 16:35 ` [PATCH RT 4/4] Linux 3.10.70-rt75-rc2 Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2015-03-17 16:30 [PATCH RT 0/4] Linux 3.12.38-rt53-rc2 Steven Rostedt
2015-03-17 16:30 ` [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Steven Rostedt
2015-03-17 16:25 [PATCH RT 0/4] Linux 3.14.34-rt32-rc2 Steven Rostedt
2015-03-17 16:25 ` [PATCH RT 2/4] Revert "timers: do not raise softirq unconditionally" Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324181034.GD1321@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=C.Emde@osadl.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).