From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Carsten Emde <C.Emde@osadl.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
RT-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH V2 RESEND 1/1] Clocksource: Add sched_clock to Atmel TCB clocksource
Date: Thu, 11 Jun 2015 17:15:33 +0200 [thread overview]
Message-ID: <20150611151533.GK16115@linutronix.de> (raw)
In-Reply-To: <556E2945.4090800@osadl.org>
* Carsten Emde | 2015-06-03 00:08:05 [+0200]:
>@@ -339,6 +346,10 @@ static int __init tcb_clksrc_init(void)
> if (ret)
> goto err_disable_t1;
>
>+ local_irq_save(flags);
>+ sched_clock_register(sched_clock_get_cycles, 32, divided_rate);
>+ local_irq_restore(flags);
The other sched_clock_register() users don't do this and are invoked via
CLOCKSOURCE_OF_DECLARE / clocksource_of_init() and this is probably
early enough so the irqs stay off.
Since this is not -RT specific at all, do you mind routing it via ARM/
clocksource folks? They also may have an idea what is stopping them from
using clocksource_of_init() so you wouldn't have to disable interrupts
here.
> /* channel 2: periodic and oneshot timer support */
> ret = setup_clkevents(tc, clk32k_divisor_idx);
> if (ret)
Sebastian
prev parent reply other threads:[~2015-06-11 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 21:46 [PATCH V2 1/1] Clocksource: Add sched_clock to Atmel TCB clocksource Carsten Emde
2015-06-02 22:08 ` [PATCH V2 RESEND " Carsten Emde
2015-06-11 15:15 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611151533.GK16115@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=C.Emde@osadl.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).