linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Carsten Emde <C.Emde@osadl.org>,
	Linux RT Users <linux-rt-users@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [OSADL QA 3.18.9-rt5 #1]
Date: Thu, 11 Jun 2015 17:27:02 +0200	[thread overview]
Message-ID: <20150611152702.GL16115@linutronix.de> (raw)
In-Reply-To: <20150513123427.2ff23a9a@gandalf.local.home>

* Steven Rostedt | 2015-05-13 12:34:27 [-0400]:

>Found the bug. The above actually changes the code
>for !CONFIG_PREEMPT_RT_FULL. You still need to keep that
>
>	if (in_irq())
>
>check, otherwise you can call irq_work_tick() from softirq in non RT
>configs, which talking to Peter Zijlstra, is a no no.
>
>Note, my tests were failing on CONFIG_PREEMPT_LL (low latency).

This was removed by mistake. Obviously. I am adding the chunk back:

--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1450,7 +1450,8 @@ void update_process_times(int user_tick)
 	run_local_timers();
 	rcu_check_callbacks(user_tick);
 #if defined(CONFIG_IRQ_WORK) && !defined(CONFIG_PREEMPT_RT_FULL)
-	irq_work_tick();
+	if (in_irq())
+		irq_work_tick();
 #endif
 	run_posix_cpu_timers(p);
 }

Sebastian

      reply	other threads:[~2015-06-11 15:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 22:52 [OSADL QA 3.18.9-rt5 #1] Carsten Emde
2015-04-09 12:37 ` Sebastian Andrzej Siewior
2015-04-09 16:53 ` Sebastian Andrzej Siewior
2015-04-10 12:36   ` Sebastian Andrzej Siewior
2015-04-11  1:35     ` Carsten Emde
2015-04-20 21:22       ` [RESOLVED OSADL " Carsten Emde
2015-05-12  0:15     ` [OSADL " Steven Rostedt
2015-05-13  8:12       ` Sebastian Andrzej Siewior
2015-05-13 15:23         ` Steven Rostedt
2015-05-13 16:34     ` Steven Rostedt
2015-06-11 15:27       ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150611152702.GL16115@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=C.Emde@osadl.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).