From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-rt-users@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>
Subject: Re: [4.1.2-rt1] build failure
Date: Mon, 20 Jul 2015 17:38:03 +0200 [thread overview]
Message-ID: <20150720153803.GB9559@linutronix.de> (raw)
In-Reply-To: <55A931A2.9040807@ti.com>
* Grygorii Strashko | 2015-07-17 19:47:30 [+0300]:
> CC kernel/pid_namespace.o
>In file included from kernel/pid_namespace.c:11:0:
>include/linux/pid.h: In function 'get_pid':
>include/linux/pid.h:78:3: error: implicit declaration of function 'atomic_inc' [-Werror=implicit-function-declaration]
> atomic_inc(&pid->count);
> ^
this is one of the patches I've thrown away because it looked not
needed. On vanilla this header gets sucked in via
include/linux/spinlock.h but on -RT we don't need it and we get this.
>The below diff fixes an issue for me:
>diff --git a/include/linux/pid.h b/include/linux/pid.h
>index 23705a53..2cc64b7 100644
>--- a/include/linux/pid.h
>+++ b/include/linux/pid.h
>@@ -2,6 +2,7 @@
> #define _LINUX_PID_H
>
> #include <linux/rcupdate.h>
>+#include <linux/atomic.h>
>
> enum pid_type
> {
If you manage so send me this as a proper patch then I could include it
into the patchset.
Sebastian
prev parent reply other threads:[~2015-07-20 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 16:47 [4.1.2-rt1] build failure Grygorii Strashko
2015-07-20 15:38 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720153803.GB9559@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=grygorii.strashko@ti.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).