Re: RCU splat on boot from an idle CPU

[Philipp Schrader <philipp@peloton-tech.com>]

On Wed, Sep 02, 2015 at 04:07:29PM -0700, Paul E. McKenney wrote:
> On Wed, Sep 02, 2015 at 03:10:04PM -0700, Philipp Schrader wrote:
> > I've got the following patch now that makes the splat disappear:
> > 
> > diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
> > index aaade2e..d0e1d0e 100644
> > --- a/kernel/trace/trace_irqsoff.c
> > +++ b/kernel/trace/trace_irqsoff.c
> > @@ -450,7 +450,7 @@ EXPORT_SYMBOL_GPL(stop_critical_timings);
> >  #ifdef CONFIG_PROVE_LOCKING
> >  void time_hardirqs_on(unsigned long a0, unsigned long a1)
> >  {
> > -       trace_preemptirqsoff_hist(IRQS_ON, 0);
> > +       trace_preemptirqsoff_hist_rcuidle(IRQS_ON, 0);
> >         if (!preempt_trace() && irq_trace())
> >                 stop_critical_timing(a0, a1);
> >  }
> > @@ -459,7 +459,7 @@ void time_hardirqs_off(unsigned long a0, unsigned long a1)
> >  {
> >         if (!preempt_trace() && irq_trace())
> >                 start_critical_timing(a0, a1);
> > -       trace_preemptirqsoff_hist(IRQS_OFF, 1);
> > +       trace_preemptirqsoff_hist_rcuidle(IRQS_OFF, 1);
> >  }
> > 
> >  #else /* !CONFIG_PROVE_LOCKING */
> > 
> > Does that look reasonable?
> > Or could this cause a problem down the road?
> 
> Looks good to me!

Should I submit a patch for this or is this just a fix for my particular kernel
configuration? I don't yet understand the code well enough to know the answer.
Thanks,
Philipp