From: Henrik Austad <haustad@cisco.com>
To: John Kacur <jkacur@redhat.com>
Cc: linux-rt-users@vger.kernel.org, Clark Williams <williams@redhat.com>
Subject: Re: [PATCH 3/4] Android: clean up the bypass ifdeffery
Date: Wed, 7 Oct 2015 13:14:24 +0200 [thread overview]
Message-ID: <20151007111424.GA21765@laethe.rd.cisco.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1510071231260.14006@riemann>
On Wed, Oct 07, 2015 at 12:34:11PM +0200, John Kacur wrote:
>
>
> On Tue, 6 Oct 2015, Henrik Austad wrote:
>
> > 88af643971b9 (android: adjust target for android) introduced some really
> > ugly ifdefs to avoid calling into pthread_barrier_wait and
> > pthread_barrier_init.
> >
> > This patch attempts to coalesce this into a single place and let the
> > compiler handle the linking so that cyclictest.c is untouched by evil
> > ifdefs.
> >
> > Compiled and tested on:
> > - x86_64 (v3.13 kernel)
> > - tilegx (v3.10 kernel)
> > - arm64 android (v3.10 kernel)
> >
> > Signed-off-by: Henrik Austad <haustad@cisco.com>
> > Cc: Clark Williams <williams@redhat.com>
> > Cc: John Kacur <jkacur@redhat.com>
> > ---
> > Makefile | 2 +-
> > include/bionic.h | 32 ++++++++++++++++++++++++++++++++
> > src/arch/bionic/Makefile | 4 +---
> > src/cyclictest/cyclictest.c | 25 +++----------------------
> > 4 files changed, 37 insertions(+), 26 deletions(-)
> > create mode 100644 include/bionic.h
> >
> > diff --git a/Makefile b/Makefile
> > index 2d20ea4..24ef8fe 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -22,7 +22,7 @@ bindir ?= $(prefix)/bin
> > mandir ?= $(prefix)/share/man
> > srcdir ?= $(prefix)/src
> >
> > -CFLAGS ?= -Wall -Wno-nonnull
> > +CFLAGS ?= -Wall -Wno-nonnull -Iinclude/
> > CPPFLAGS += -D_GNU_SOURCE -Isrc/include
>
> We already have an include dir. Why aren't you using it?
> If you think it would be cleaner to create your own include dir, you at
> least have to put it some where in the src dir
You're right!
moving it to src/include/ now, do you want a new patch right away, or shall
I wait for v0.96-devel before submitting?
--
Henrik Austad
TIPBU Eng
Cisco Systems Norway
next prev parent reply other threads:[~2015-10-07 11:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 9:08 [PATCH 1/4] Properly test for return-values from read() and write() Henrik Austad
2015-10-06 9:08 ` [PATCH 2/4] signaltest: properly test return value from system() Henrik Austad
2015-10-07 10:44 ` John Kacur
2015-10-06 9:08 ` [PATCH 3/4] Android: clean up the bypass ifdeffery Henrik Austad
2015-10-07 10:34 ` John Kacur
2015-10-07 11:14 ` Henrik Austad [this message]
2015-10-07 11:55 ` John Kacur
2015-10-06 9:08 ` [PATCH 4/4] cyclictest: move redefine of CPUSET back to uclib Henrik Austad
2015-10-07 10:28 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007111424.GA21765@laethe.rd.cisco.com \
--to=haustad@cisco.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).