From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Yang Shi <yang.shi@linaro.org>
Cc: tglx@linutronix.de, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH v2] rt: x86: enable preemption in IST exception for x86-32
Date: Tue, 22 Dec 2015 13:06:28 +0100 [thread overview]
Message-ID: <20151222120628.GA27274@linutronix.de> (raw)
In-Reply-To: <1450134404-16662-1-git-send-email-yang.shi@linaro.org>
* Yang Shi | 2015-12-14 15:06:44 [-0800]:
>Mainline kernel commit 959274753857efe9c5f1ba35fe727f51e9aa128d
>("x86, traps: Track entry into and exit from IST context"), introduced
>ist_enter which disables preemption uncondiontionally for both x86-64 and
>x86-32. However, x86-32 does not have an IST and the stack still belongs to
>the current task and there is no problem in scheduling out the task.
no no. So from a quick look I *assumed* you merged your v1 and revert of the
Steven's patch into one piece. But now I see that you don't disable preemption
64bit which means you revert upstream change.
Here is what happens:
- I drop your v2
- I merge your v1 with updated patch description
- I revert "x86: Do not disable preemption in int3 on 32bit". If someone
wants to skip the delayed signal on 32bit please address this upstream
first (that is skip the preempt_disable() on 32bit if it is not
required there).
- Yang Shi, please send a changelong if you send incremental patches.
Sebastian
next prev parent reply other threads:[~2015-12-22 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 23:06 [PATCH v2] rt: x86: enable preemption in IST exception for x86-32 Yang Shi
2015-12-22 12:06 ` Sebastian Andrzej Siewior [this message]
2015-12-22 18:12 ` Shi, Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222120628.GA27274@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=yang.shi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).