From: Jeff Epler <jepler@unpythonic.net>
To: Khem Raj <raj.khem@gmail.com>
Cc: williams@redhat.com, jkacur@redhat.com, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] Makefile: Set CC/AR variable only if it doesn't have a value
Date: Mon, 4 Jan 2016 07:39:04 -0600 [thread overview]
Message-ID: <20160104133903.GG92593@unpythonic.net> (raw)
In-Reply-To: <1451847271-31571-1-git-send-email-raj.khem@gmail.com>
I believe the patch does not have the desired effect, because make(1)
always sets CC automatically:
$ cat raj.mk
CROSS_COMPILE=x86_64-linux-gnu-
CC?=$(CROSS_COMPILE)gcc
.PHONY: default
default:
@echo CC=$(CC)
$ make -f raj.mk
CC=cc
With your patch, those who specify CROSS_COMPILE, or for whom gcc and cc
are different, will get different (worse) behavior.
I believe this idea has been discussed before, but it is hard to search
for because few search engines will let you search on "CC ?=" and not
just ignore the "?=".
Also I am not sure why you are submitting this patch on -rt-users, it
doesn't seem to be particularly relevant to the RT patchset.
Jeff
next prev parent reply other threads:[~2016-01-04 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 18:54 [PATCH] Makefile: Set CC/AR variable only if it doesn't have a value Khem Raj
2016-01-04 13:39 ` Jeff Epler [this message]
2016-01-04 14:40 ` Clark Williams
2016-01-05 3:12 ` Jeff Epler
2016-01-04 16:20 ` Khem Raj
2016-01-04 16:25 ` Uwe Kleine-König
2016-01-05 21:15 ` Henrik Austad
2016-01-05 21:20 ` Khem Raj
2016-01-05 21:42 ` Uwe Kleine-König
2016-01-04 19:21 ` Arnout Vandecappelle
2016-01-04 23:13 ` Khem Raj
2016-01-05 22:59 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104133903.GG92593@unpythonic.net \
--to=jepler@unpythonic.net \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=raj.khem@gmail.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).