From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Henrik Austad <henrik@austad.us>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
uriahheep@gmail.com, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sched: migrate_disable() and del_timer_sync() issues with !CONFIG_SMP
Date: Fri, 15 Jan 2016 17:23:10 +0100 [thread overview]
Message-ID: <20160115162310.GC3781@linutronix.de> (raw)
In-Reply-To: <1451954450-29298-1-git-send-email-henrik@austad.us>
* Henrik Austad | 2016-01-05 01:40:50 [+0100]:
>diff --git a/include/linux/timer.h b/include/linux/timer.h
>index 299d2b78591f..79889be97b3b 100644
>--- a/include/linux/timer.h
>+++ b/include/linux/timer.h
>@@ -225,7 +225,7 @@ extern void add_timer(struct timer_list *timer);
>
> extern int try_to_del_timer_sync(struct timer_list *timer);
>
>-#if defined(CONFIG_SMP) || defined(CONFIG_PREEMPT_RT_FULL)
>+#if defined(CONFIG_SMP) && defined(CONFIG_PREEMPT_RT_FULL)
I think I fixed this in the meantime (-rt3 once it is out) but this
needs to be || here.
> extern int del_timer_sync(struct timer_list *timer);
> #else
> # define del_timer_sync(t) del_timer(t)
Sebastian
prev parent reply other threads:[~2016-01-15 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 0:40 [PATCH] sched: migrate_disable() and del_timer_sync() issues with !CONFIG_SMP Henrik Austad
2016-01-15 16:23 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115162310.GC3781@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=henrik@austad.us \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=uriahheep@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).