From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: linux-rt-users@vger.kernel.org, khilman@kernel.org,
ccross@android.com, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
daniel.lezcano@linaro.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock
Date: Mon, 18 Jan 2016 18:02:09 +0100 [thread overview]
Message-ID: <20160118170209.GA12309@linutronix.de> (raw)
In-Reply-To: <1452885673-30891-9-git-send-email-anders.roxell@linaro.org>
* Anders Roxell | 2016-01-15 20:21:12 [+0100]:
>Used multi_v7_defconfig+PREEMPT_RT_FULL=y and this caused a compilation
>warning without this fix:
>../drivers/cpuidle/coupled.c:122:21: warning: 'cpuidle_coupled_lock'
>defined but not used [-Wunused-variable]
>
>Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Could you please forward this patch upstream? The driver was introduced
in 4126c0197bc8 ("cpuidle: add support for states that affect multiple
cpus") with the cpuidle_coupled_lock variable unused. This is not -RT
specific.
>---
> drivers/cpuidle/coupled.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c
>index 344058f..d5657d5 100644
>--- a/drivers/cpuidle/coupled.c
>+++ b/drivers/cpuidle/coupled.c
>@@ -119,7 +119,6 @@ struct cpuidle_coupled {
>
> #define CPUIDLE_COUPLED_NOT_IDLE (-1)
>
>-static DEFINE_MUTEX(cpuidle_coupled_lock);
> static DEFINE_PER_CPU(struct call_single_data, cpuidle_coupled_poke_cb);
>
> /*
Sebastian
next prev parent reply other threads:[~2016-01-18 17:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 19:21 [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Anders Roxell
2016-01-15 19:21 ` [PATCH 1/9] drivers/clocksource: timer-atmel-pit: fix irq name Anders Roxell
2016-01-15 19:21 ` [PATCH 2/9] drivers/clocksource: timer-atmel-pit: fix forward declaration Anders Roxell
2016-01-15 19:21 ` [PATCH 3/9] drivers/clocksource: timer-atmel-pit: fix unused var 'ret' Anders Roxell
2016-01-15 19:21 ` [PATCH 4/9] drivers/clocksource: timer-atmel-st: undeclared " Anders Roxell
2016-01-15 19:21 ` [PATCH 5/9] drivers/clocksource: timer-atmel-st: fix unused " Anders Roxell
[not found] ` <CAGt3f4kZAL65+yeNh1qrAbap4SJNwQrSa=5QF0LN9Mh8ew5HSQ@mail.gmail.com>
2016-01-18 18:34 ` Brian Silverman
2016-01-20 21:33 ` Anders Roxell
2016-01-20 21:34 ` Anders Roxell
2016-01-21 8:14 ` Sebastian Andrzej Siewior
2016-01-15 19:21 ` [PATCH 6/9] drivers/clocksource: timer-atmel-st: undeclared var 'irq' Anders Roxell
2016-01-15 19:21 ` [PATCH 7/9] kernel/time: hrtimer: fix forward declaration Anders Roxell
2016-01-15 19:21 ` [PATCH 8/9] drivers/cpuidle: coupled: fix warning cpuidle_coupled_lock Anders Roxell
2016-01-18 17:02 ` Sebastian Andrzej Siewior [this message]
2016-01-20 21:28 ` Anders Roxell
2016-01-15 19:21 ` [PATCH 9/9] driver/gpio: gpio-omap: fix incompatible pointer type Anders Roxell
2016-01-18 14:29 ` Grygorii Strashko
2016-01-20 21:29 ` Anders Roxell
2016-01-18 17:54 ` [PATCH 0/9] v4.4-rt2: fix compilation warnings and errors Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118170209.GA12309@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anders.roxell@linaro.org \
--cc=ccross@android.com \
--cc=daniel.lezcano@linaro.org \
--cc=khilman@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).