From: Clark Williams <williams@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [ANNOUNCE] 4.4.1-rt6
Date: Mon, 15 Feb 2016 22:53:58 -0600 [thread overview]
Message-ID: <20160215225358.135e9227@sluggy.hsv.redhat.com> (raw)
In-Reply-To: <20160212234708.GB7694@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]
On Sat, 13 Feb 2016 00:47:08 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> - There is a useless rcu_bh thread which has been deactivated.
>
For some strange reason I had RCU_TORTURE_TEST defined in my config. This caused my compile to blow up because kernel/rcu/rcutorture.c wanted to test the (now ifdef'ed out) rcu_bh routines. This fixes the compile issue but is untested for actually *running* rcutorture. I'll try that on a test box tomorrow.
Clark
From a835ff3aad772520d34548dc336925788a649b17 Mon Sep 17 00:00:00 2001
From: Clark Williams <williams@redhat.com>
Date: Mon, 15 Feb 2016 22:48:04 -0600
Subject: [PATCH] rcutorture: comment out rcu_bh ops on PREEMPT_RT_FULL
RT has dropped support of rcu_bh, comment out in rcutorture.
Signed-off-by: Clark Williams <williams@redhat.com>
---
kernel/rcu/rcutorture.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index d89328e260df..5bb3364a6284 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -390,6 +390,7 @@ static struct rcu_torture_ops rcu_ops = {
.name = "rcu"
};
+#ifndef CONFIG_PREEMPT_RT_FULL
/*
* Definitions for rcu_bh torture testing.
*/
@@ -429,6 +430,12 @@ static struct rcu_torture_ops rcu_bh_ops = {
.name = "rcu_bh"
};
+#else
+static struct rcu_torture_ops rcu_bh_ops = {
+ .ttype = INVALID_RCU_FLAVOR,
+};
+#endif
+
/*
* Don't even think about trying any of these in real life!!!
* The names includes "busted", and they really means it!
--
2.5.0
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-02-16 4:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 23:47 [ANNOUNCE] 4.4.1-rt6 Sebastian Andrzej Siewior
2016-02-15 17:25 ` Mike Galbraith
2016-02-16 1:51 ` Mike Galbraith
2016-02-16 4:53 ` Clark Williams [this message]
2016-02-16 19:19 ` Clark Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215225358.135e9227@sluggy.hsv.redhat.com \
--to=williams@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).