linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <moorray3@wp.pl>
To: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
Cc: Josh Cartwright <joshc@ni.com>, <linux-serial@vger.kernel.org>,
	<kubakici@wp.pl>, <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH] sc16is7xx: switch to threaded irq for fixing RT issues
Date: Thu, 18 Feb 2016 08:46:34 +0000	[thread overview]
Message-ID: <20160218084634.017c3ab4@laptop> (raw)
In-Reply-To: <56C572E4.20906@prevas.dk>

On Thu, 18 Feb 2016 08:29:40 +0100, Sean Nyekjær wrote:
> > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> > index e78fa99..1bb5c0e 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -1257,7 +1257,7 @@ static int sc16is7xx_probe(struct device *dev,
> >   
> >   	/* Setup interrupt */
> >   	ret = devm_request_irq(dev, irq, sc16is7xx_irq,
> > -			       IRQF_ONESHOT | flags, dev_name(dev), s);
> > +			       flags, dev_name(dev), s);
> >   	if (!ret)
> >   		return 0;
> >  
> Wow, nice that you CC'd the RT guys :-)
> 
> Josh that was it, it runs without deadlocks now :-D
> 
> Thank you.
> 
> Jakub, is this fix ok? Who is making this into a PATCH?

Yes, in fact similar patch circulated at some point but the author
flaked out before it was ready for merging.

Josh could you submit officially?  Please CC stable for 4.1+.
Fixes: 9e6f4ca3e567 ("sc16is7xx: use kthread_worker for tx_work and irq")

Thanks a lot!
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-02-18  8:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1455523133-29895-1-git-send-email-sean.nyekjaer@prevas.dk>
     [not found] ` <20160215220810.11529101@laptop>
     [not found]   ` <56C2D1A7.1030908@prevas.dk>
     [not found]     ` <20160216210250.34c2f07f@laptop>
     [not found]       ` <56C41FA5.4010605@prevas.dk>
2016-02-17 21:54         ` [PATCH] sc16is7xx: switch to threaded irq for fixing RT issues Jakub Kicinski
2016-02-17 23:25           ` Josh Cartwright
2016-02-18  7:29             ` Sean Nyekjær
2016-02-18  8:46               ` Jakub Kicinski [this message]
2016-02-18 17:26                 ` [PATCH] sc16is7xx: drop bogus use of IRQF_ONESHOT Josh Cartwright
2016-03-08 12:43                   ` Sean Nyekjær
2016-09-09 13:14                   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218084634.017c3ab4@laptop \
    --to=moorray3@wp.pl \
    --cc=joshc@ni.com \
    --cc=kubakici@wp.pl \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sean.nyekjaer@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).