* [GIT PULL 00/11] perf/core improvements and fixes
@ 2016-02-23 20:00 Arnaldo Carvalho de Melo
2016-02-23 20:00 ` [PATCH 01/11] tools lib traceevent: Implement '%' operation Arnaldo Carvalho de Melo
2016-02-24 7:23 ` [GIT PULL 00/11] perf/core improvements and fixes Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-23 20:00 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter, Andi Kleen,
Daniel Bristot de Oliveira, David Ahern, Jiri Olsa, Juri Lelli,
linux-rt-users, Namhyung Kim, Peter Zijlstra, Stephane Eranian,
Steven Rostedt, Thomas Gleixner, Wang Nan,
Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling, this is on top of the perf-core-for-mingo
submitted recently,
- Arnaldo
The following changes since commit 03e0a7df3efd959e40cd7ff40b1fabddc234ec5a:
perf tools: Introduce bpf-output event (2016-02-22 14:37:21 -0300)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
for you to fetch changes up to bea2400621836b028d82c3d6a74053921d70dbd7:
perf tools: Remove strbuf_{remove,splice}() (2016-02-23 16:21:04 -0300)
----------------------------------------------------------------
perf/core improvements and fixes:
User visible:
- Don't stop PMU parsing on alias parse error, allowing the
addition of new sysfs PMU files without breaking old tools (Andi Kleen)
- Implement '%' operation in libtraceevent (Daniel Bristot de Oliveira)
- Allow specifying events via -e in 'perf mem record', also listing what events
can be specified via 'perf mem record -e list' (Jiri Olsa)
- Improve support to 'data_src', 'weight' and 'addr' fields in
'perf script' (Jiri Olsa)
Infrastructure:
- Export cacheline routines (Jiri Olsa)
- Remove strbuf_{remove,splice}(), dead code (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Andi Kleen (1):
perf tools: Dont stop PMU parsing on alias parse error
Arnaldo Carvalho de Melo (2):
perf help: No need to use strbuf_remove()
perf tools: Remove strbuf_{remove,splice}()
Daniel Bristot de Oliveira (1):
tools lib traceevent: Implement '%' operation
Jiri Olsa (7):
perf tools: Make cl_address global
perf tools: Introduce cl_offset function
perf tools: Add monitored events array
perf mem: Add -e record option
perf tools: Use ARRAY_SIZE in mem sort display functions
perf script: Add data_src and weight column definitions
perf script: Display addr/data_src/weight columns for raw events
tools/lib/traceevent/event-parse.c | 4 +++
tools/perf/builtin-help.c | 3 +-
tools/perf/builtin-mem.c | 74 +++++++++++++++++++++++++++++++++-----
tools/perf/builtin-script.c | 23 +++++++++++-
tools/perf/util/Build | 1 +
tools/perf/util/mem-events.c | 51 ++++++++++++++++++++++++++
tools/perf/util/mem-events.h | 22 ++++++++++++
tools/perf/util/pmu.c | 15 ++++----
tools/perf/util/sort.c | 15 ++------
tools/perf/util/sort.h | 11 ++++++
tools/perf/util/strbuf.c | 24 -------------
tools/perf/util/strbuf.h | 2 --
12 files changed, 188 insertions(+), 57 deletions(-)
create mode 100644 tools/perf/util/mem-events.c
create mode 100644 tools/perf/util/mem-events.h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 01/11] tools lib traceevent: Implement '%' operation
2016-02-23 20:00 [GIT PULL 00/11] perf/core improvements and fixes Arnaldo Carvalho de Melo
@ 2016-02-23 20:00 ` Arnaldo Carvalho de Melo
2016-02-24 7:23 ` [GIT PULL 00/11] perf/core improvements and fixes Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-02-23 20:00 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Daniel Bristot de Oliveira, Juri Lelli,
Peter Zijlstra, Thomas Gleixner, linux-rt-users,
Arnaldo Carvalho de Melo
From: Daniel Bristot de Oliveira <bristot@redhat.com>
The operation '%' is not implemented on event-parse.c, causing an error
when parsing events with '%' the operation in its printk format. For
example,
# perf record -e sched:sched_deadline_yield ~/yield-test
Warning: [sched:sched_deadline_yield] unknown op '%'
....
# perf script
Warning: [sched:sched_deadline_yield] unknown op '%'
test 1641 [006] 3364.109319: sched:sched_deadline_yield: \
[FAILED TO PARSE] now=3364109314595 \
deadline=3364139295135 runtime=19975597
This patch implements the '%' operation. With this patch, we see the
correct output:
# perf record -e sched:sched_deadline_yield ~/yield-test
No Warning
# perf script
yield-test 4005 [001] 4623.650978: sched:sched_deadline_yield: \
now=4623.650974050 \
deadline=4623.680957364 remaining_runtime=19979611
Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Juri Lelli <juri.lelli@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>
Link: http://lkml.kernel.org/r/5c96a395c56cea6d3d13d949051bdece86cc26e0.1456157869.git.bristot@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/traceevent/event-parse.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index c3bd294a63d1..575e75174087 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -1951,6 +1951,7 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok)
strcmp(token, "*") == 0 ||
strcmp(token, "^") == 0 ||
strcmp(token, "/") == 0 ||
+ strcmp(token, "%") == 0 ||
strcmp(token, "<") == 0 ||
strcmp(token, ">") == 0 ||
strcmp(token, "<=") == 0 ||
@@ -3689,6 +3690,9 @@ eval_num_arg(void *data, int size, struct event_format *event, struct print_arg
case '/':
val = left / right;
break;
+ case '%':
+ val = left % right;
+ break;
case '*':
val = left * right;
break;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [GIT PULL 00/11] perf/core improvements and fixes
2016-02-23 20:00 [GIT PULL 00/11] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-02-23 20:00 ` [PATCH 01/11] tools lib traceevent: Implement '%' operation Arnaldo Carvalho de Melo
@ 2016-02-24 7:23 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2016-02-24 7:23 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Andi Kleen,
Daniel Bristot de Oliveira, David Ahern, Jiri Olsa, Juri Lelli,
linux-rt-users, Namhyung Kim, Peter Zijlstra, Stephane Eranian,
Steven Rostedt, Thomas Gleixner, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling, this is on top of the perf-core-for-mingo
> submitted recently,
>
> - Arnaldo
>
> The following changes since commit 03e0a7df3efd959e40cd7ff40b1fabddc234ec5a:
>
> perf tools: Introduce bpf-output event (2016-02-22 14:37:21 -0300)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-2
>
> for you to fetch changes up to bea2400621836b028d82c3d6a74053921d70dbd7:
>
> perf tools: Remove strbuf_{remove,splice}() (2016-02-23 16:21:04 -0300)
>
> ----------------------------------------------------------------
> perf/core improvements and fixes:
>
> User visible:
>
> - Don't stop PMU parsing on alias parse error, allowing the
> addition of new sysfs PMU files without breaking old tools (Andi Kleen)
>
> - Implement '%' operation in libtraceevent (Daniel Bristot de Oliveira)
>
> - Allow specifying events via -e in 'perf mem record', also listing what events
> can be specified via 'perf mem record -e list' (Jiri Olsa)
>
> - Improve support to 'data_src', 'weight' and 'addr' fields in
> 'perf script' (Jiri Olsa)
>
> Infrastructure:
>
> - Export cacheline routines (Jiri Olsa)
>
> - Remove strbuf_{remove,splice}(), dead code (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Andi Kleen (1):
> perf tools: Dont stop PMU parsing on alias parse error
>
> Arnaldo Carvalho de Melo (2):
> perf help: No need to use strbuf_remove()
> perf tools: Remove strbuf_{remove,splice}()
>
> Daniel Bristot de Oliveira (1):
> tools lib traceevent: Implement '%' operation
>
> Jiri Olsa (7):
> perf tools: Make cl_address global
> perf tools: Introduce cl_offset function
> perf tools: Add monitored events array
> perf mem: Add -e record option
> perf tools: Use ARRAY_SIZE in mem sort display functions
> perf script: Add data_src and weight column definitions
> perf script: Display addr/data_src/weight columns for raw events
>
> tools/lib/traceevent/event-parse.c | 4 +++
> tools/perf/builtin-help.c | 3 +-
> tools/perf/builtin-mem.c | 74 +++++++++++++++++++++++++++++++++-----
> tools/perf/builtin-script.c | 23 +++++++++++-
> tools/perf/util/Build | 1 +
> tools/perf/util/mem-events.c | 51 ++++++++++++++++++++++++++
> tools/perf/util/mem-events.h | 22 ++++++++++++
> tools/perf/util/pmu.c | 15 ++++----
> tools/perf/util/sort.c | 15 ++------
> tools/perf/util/sort.h | 11 ++++++
> tools/perf/util/strbuf.c | 24 -------------
> tools/perf/util/strbuf.h | 2 --
> 12 files changed, 188 insertions(+), 57 deletions(-)
> create mode 100644 tools/perf/util/mem-events.c
> create mode 100644 tools/perf/util/mem-events.h
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-24 7:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 20:00 [GIT PULL 00/11] perf/core improvements and fixes Arnaldo Carvalho de Melo
2016-02-23 20:00 ` [PATCH 01/11] tools lib traceevent: Implement '%' operation Arnaldo Carvalho de Melo
2016-02-24 7:23 ` [GIT PULL 00/11] perf/core improvements and fixes Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).