* [patch] sched,rt: __always_inline preemptible_lazy()
2016-01-21 12:54 ` Sebastian Andrzej Siewior
@ 2016-02-21 15:11 ` Mike Galbraith
0 siblings, 0 replies; 5+ messages in thread
From: Mike Galbraith @ 2016-02-21 15:11 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: Thomas Gleixner, LKML, linux-rt-users
homer: # nm kernel/sched/core.o|grep preemptible_lazy
00000000000000b5 t preemptible_lazy
echo wakeup_rt > current_tracer ==> Welcome to infinity.
Signed-off-bx: Mike Galbraith <umgwanakikbuti@gmail.com>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3469,7 +3469,7 @@ static void __sched notrace preempt_sche
* set by a RT task. Oterwise we try to avoid beeing scheduled out as long as
* preempt_lazy_count counter >0.
*/
-static int preemptible_lazy(void)
+static __always_inline int preemptible_lazy(void)
{
if (test_thread_flag(TIF_NEED_RESCHED))
return 1;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] sched,rt: __always_inline preemptible_lazy()
@ 2016-02-22 3:36 Hillf Danton
2016-02-22 4:03 ` Mike Galbraith
0 siblings, 1 reply; 5+ messages in thread
From: Hillf Danton @ 2016-02-22 3:36 UTC (permalink / raw)
To: Mike Galbraith
Cc: 'Sebastian Andrzej Siewior', 'Thomas Gleixner',
'LKML', 'linux-rt-users'
>
> homer: # nm kernel/sched/core.o|grep preemptible_lazy
> 00000000000000b5 t preemptible_lazy
>
> echo wakeup_rt > current_tracer ==> Welcome to infinity.
>
> Signed-off-bx: Mike Galbraith <umgwanakikbuti@gmail.com>
> ---
Fat finger?
BTW, would you please make a better description of the
problem this patch is trying to address/fix?
Hillf
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3469,7 +3469,7 @@ static void __sched notrace preempt_sche
> * set by a RT task. Oterwise we try to avoid beeing scheduled out as long as
> * preempt_lazy_count counter >0.
> */
> -static int preemptible_lazy(void)
> +static __always_inline int preemptible_lazy(void)
> {
> if (test_thread_flag(TIF_NEED_RESCHED))
> return 1;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] sched,rt: __always_inline preemptible_lazy()
2016-02-22 3:36 [patch] sched,rt: __always_inline preemptible_lazy() Hillf Danton
@ 2016-02-22 4:03 ` Mike Galbraith
2016-02-22 5:16 ` Hillf Danton
2016-02-26 10:17 ` Sebastian Andrzej Siewior
0 siblings, 2 replies; 5+ messages in thread
From: Mike Galbraith @ 2016-02-22 4:03 UTC (permalink / raw)
To: Hillf Danton
Cc: 'Sebastian Andrzej Siewior', 'Thomas Gleixner',
'LKML', 'linux-rt-users'
On Mon, 2016-02-22 at 11:36 +0800, Hillf Danton wrote:
> >
> > homer: # nm kernel/sched/core.o|grep preemptible_lazy
> > 00000000000000b5 t preemptible_lazy
> >
> > echo wakeup_rt > current_tracer ==> Welcome to infinity.
> >
> > Signed-off-bx: Mike Galbraith <umgwanakikbuti@gmail.com>
> > ---
>
> Fat finger?
Yeah, my fingers don't take direction all that well.
> BTW, would you please make a better description of the
> problem this patch is trying to address/fix?
Ok, I thought it was clear what happens.
sched,rt: __always_inline preemptible_lazy()
Functions called within a notrace function must either also be
notrace or be inlined, lest recursion blow the stack.
homer: # nm kernel/sched/core.o|grep preemptible_lazy
00000000000000b5 t preemptible_lazy
echo wakeup_rt > current_tracer ==> Welcome to infinity.
Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3469,7 +3469,7 @@ static void __sched notrace preempt_sche
* set by a RT task. Oterwise we try to avoid beeing scheduled out as long as
* preempt_lazy_count counter >0.
*/
-static int preemptible_lazy(void)
+static __always_inline int preemptible_lazy(void)
{
if (test_thread_flag(TIF_NEED_RESCHED))
return 1;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] sched,rt: __always_inline preemptible_lazy()
2016-02-22 4:03 ` Mike Galbraith
@ 2016-02-22 5:16 ` Hillf Danton
2016-02-26 10:17 ` Sebastian Andrzej Siewior
1 sibling, 0 replies; 5+ messages in thread
From: Hillf Danton @ 2016-02-22 5:16 UTC (permalink / raw)
To: 'Mike Galbraith'
Cc: 'Sebastian Andrzej Siewior', 'Thomas Gleixner',
'LKML', 'linux-rt-users'
>
> sched,rt: __always_inline preemptible_lazy()
>
> Functions called within a notrace function must either also be
> notrace or be inlined, lest recursion blow the stack.
>
> homer: # nm kernel/sched/core.o|grep preemptible_lazy
> 00000000000000b5 t preemptible_lazy
>
> echo wakeup_rt > current_tracer ==> Welcome to infinity.
>
> Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
> ---
Thank you, Mike.
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> kernel/sched/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3469,7 +3469,7 @@ static void __sched notrace preempt_sche
> * set by a RT task. Oterwise we try to avoid beeing scheduled out as long as
> * preempt_lazy_count counter >0.
> */
> -static int preemptible_lazy(void)
> +static __always_inline int preemptible_lazy(void)
> {
> if (test_thread_flag(TIF_NEED_RESCHED))
> return 1;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] sched,rt: __always_inline preemptible_lazy()
2016-02-22 4:03 ` Mike Galbraith
2016-02-22 5:16 ` Hillf Danton
@ 2016-02-26 10:17 ` Sebastian Andrzej Siewior
1 sibling, 0 replies; 5+ messages in thread
From: Sebastian Andrzej Siewior @ 2016-02-26 10:17 UTC (permalink / raw)
To: Mike Galbraith
Cc: Hillf Danton, 'Thomas Gleixner', 'LKML',
'linux-rt-users'
* Mike Galbraith | 2016-02-22 05:03:05 [+0100]:
>sched,rt: __always_inline preemptible_lazy()
>Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
applied.
Sebastian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-26 10:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 3:36 [patch] sched,rt: __always_inline preemptible_lazy() Hillf Danton
2016-02-22 4:03 ` Mike Galbraith
2016-02-22 5:16 ` Hillf Danton
2016-02-26 10:17 ` Sebastian Andrzej Siewior
-- strict thread matches above, loose matches on Subject: below --
2016-01-18 9:08 [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port Mike Galbraith
2016-01-18 20:18 ` Sebastian Andrzej Siewior
2016-01-19 2:29 ` Mike Galbraith
2016-01-21 12:54 ` Sebastian Andrzej Siewior
2016-02-21 15:11 ` [patch] sched,rt: __always_inline preemptible_lazy() Mike Galbraith
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).