linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Josh Cartwright <joshc@ni.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH RT 4/7] net: Make synchronize_rcu_expedited() conditional on !RT_FULL
Date: Fri, 26 Feb 2016 16:44:12 -0500	[thread overview]
Message-ID: <20160226214428.525980618@goodmis.org> (raw)
In-Reply-To: 20160226214408.590103414@goodmis.org

[-- Attachment #1: 0004-net-Make-synchronize_rcu_expedited-conditional-on-RT.patch --]
[-- Type: text/plain, Size: 1447 bytes --]

3.2.77-rt111-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Josh Cartwright <joshc@ni.com>

While the use of synchronize_rcu_expedited() might make
synchronize_net() "faster", it does so at significant cost on RT
systems, as expediting a grace period forcibly preempts any
high-priority RT tasks (via the stop_machine() mechanism).

Without this change, we can observe a latency spike up to 30us with
cyclictest by rapidly unplugging/reestablishing an ethernet link.

Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Josh Cartwright <joshc@ni.com>
Cc: bigeasy@linutronix.de
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: David S. Miller <davem@davemloft.net>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20151027123153.GG8245@jcartwri.amer.corp.natinst.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 net/core/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index f7f91c97933b..b6fa0b2fd713 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6169,7 +6169,7 @@ EXPORT_SYMBOL(free_netdev);
 void synchronize_net(void)
 {
 	might_sleep();
-	if (rtnl_is_locked())
+	if (rtnl_is_locked() && !IS_ENABLED(CONFIG_PREEMPT_RT_FULL))
 		synchronize_rcu_expedited();
 	else
 		synchronize_rcu();
-- 
2.7.0

  parent reply	other threads:[~2016-02-26 21:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 21:44 [PATCH RT 0/7] Linux 3.2.77-rt111-rc1 Steven Rostedt
2016-02-26 21:44 ` [PATCH RT 1/7] rtmutex: Handle non enqueued waiters gracefully Steven Rostedt
2016-02-26 21:44 ` [PATCH RT 2/7] rtmutex: Use chainwalking control enum Steven Rostedt
2016-02-26 21:44 ` [PATCH RT 3/7] dump stack: dont disable preemption during trace Steven Rostedt
2016-02-26 21:44 ` Steven Rostedt [this message]
2016-02-26 21:44 ` [PATCH RT 5/7] sched: Introduce the trace_sched_waking tracepoint Steven Rostedt
2016-02-26 21:44 ` [PATCH RT 6/7] rtmutex: Have slowfn of rt_mutex_timed_fastlock() use enum Steven Rostedt
2016-02-26 21:44 ` [PATCH RT 7/7] Linux 3.2.77-rt111-rc1 Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2016-02-26 21:42 [PATCH RT 0/7] Linux 3.4.110-rt139-rc1 Steven Rostedt
2016-02-26 21:42 ` [PATCH RT 4/7] net: Make synchronize_rcu_expedited() conditional on !RT_FULL Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160226214428.525980618@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jkacur@redhat.com \
    --cc=joshc@ni.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).