linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	John Kacur <jkacur@redhat.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH RT 3/7] kernel: softirq: unlock with irqs on
Date: Wed, 02 Mar 2016 15:14:09 -0500	[thread overview]
Message-ID: <20160302201414.657228926@goodmis.org> (raw)
In-Reply-To: 20160302201406.143206126@goodmis.org

[-- Attachment #1: 0003-kernel-softirq-unlock-with-irqs-on.patch --]
[-- Type: text/plain, Size: 1005 bytes --]

3.4.110-rt140-rc1 stable review patch.
If anyone has any objections, please let me know.

------------------

From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

We unlock the lock while the interrupts are off. This isn't a problem
now but will get because the migrate_disable() + enable are not
symmetrical in regard to the status of interrupts.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/softirq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index ecf0ab0f7b4d..d2c870a826da 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -561,10 +561,10 @@ static int __thread_do_softirq(int cpu)
 	 */
 	if (local_softirq_pending())
 		__do_softirq_common(cpu >= 0);
-	local_unlock(local_softirq_lock);
 	unpin_current_cpu();
-	preempt_disable();
 	local_irq_enable();
+	local_unlock(local_softirq_lock);
+	preempt_disable();
 	return 0;
 }
 
-- 
2.7.0

  parent reply	other threads:[~2016-03-02 20:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 20:14 [PATCH RT 0/7] Linux 3.4.110-rt140-rc1 Steven Rostedt
2016-03-02 20:14 ` [PATCH RT 1/7] latencyhist: disable jump-labels Steven Rostedt
2016-03-02 20:14 ` [PATCH RT 2/7] kernel: migrate_disable() do fastpath in atomic & irqs-off Steven Rostedt
2016-03-02 20:14 ` Steven Rostedt [this message]
2016-03-02 20:14 ` [PATCH RT 4/7] trace: Use rcuidle version for preemptoff_hist trace point Steven Rostedt
2016-03-02 20:14 ` [PATCH RT 5/7] rcu/torture: Comment out rcu_bh ops on PREEMPT_RT_FULL Steven Rostedt
2016-03-02 20:14 ` [PATCH RT 6/7] kernel: sched: Fix preempt_disable_ip recodring for preempt_disable() Steven Rostedt
2016-03-02 20:14 ` [PATCH RT 7/7] Linux 3.4.110-rt140-rc1 Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2016-03-03  2:21 [PATCH RT 0/7] Linux 3.2.77-rt112-rc1 Steven Rostedt
2016-03-03  2:21 ` [PATCH RT 3/7] kernel: softirq: unlock with irqs on Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160302201414.657228926@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).