From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [4.4-rt PATCH] trace: use rcuidle version for preemptoff_hist trace point Date: Mon, 7 Mar 2016 19:00:09 +0100 Message-ID: <20160307180009.GF12595@linutronix.de> References: <1456262603-10075-1-git-send-email-yang.shi@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: tglx@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org To: Yang Shi Return-path: Received: from www.linutronix.de ([62.245.132.108]:46257 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350AbcCGSAR convert rfc822-to-8bit (ORCPT ); Mon, 7 Mar 2016 13:00:17 -0500 Content-Disposition: inline In-Reply-To: <1456262603-10075-1-git-send-email-yang.shi@windriver.com> Sender: linux-rt-users-owner@vger.kernel.org List-ID: * Yang Shi | 2016-02-23 13:23:23 [-0800]: >I recall the rcuidle version is used by 4.1-rt, but not sure why it is= dropped >in 4.4-rt. It looks such fix is still needed.=20 I don't recall while I removed it. It was durring v4.1 -> v4.4 port. In v4.1 we had the idle version only in time_hardirqs_on() + =E2=80=A6_off= (). You introduced it also to start_critical_timings() + stop_=E2=80=A6(). Is t= his required? In the meantime I bring back the empty macro of trace_preemptirqsoff_hist_rcuidle() back in -RT sine it breaks compile latest v4.4.3-RT9 > kernel/trace/trace_irqsoff.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff= =2Ec >index 36e584f..069942c 100644 >--- a/kernel/trace/trace_irqsoff.c >+++ b/kernel/trace/trace_irqsoff.c >@@ -421,13 +421,13 @@ void start_critical_timings(void) > { > if (preempt_trace() || irq_trace()) > start_critical_timing(CALLER_ADDR0, CALLER_ADDR1); >- trace_preemptirqsoff_hist(TRACE_START, 1); >+ trace_preemptirqsoff_hist_rcuidle(TRACE_START, 1); > } > EXPORT_SYMBOL_GPL(start_critical_timings); >=20 > void stop_critical_timings(void) > { >- trace_preemptirqsoff_hist(TRACE_STOP, 0); >+ trace_preemptirqsoff_hist_rcuidle(TRACE_STOP, 0); > if (preempt_trace() || irq_trace()) > stop_critical_timing(CALLER_ADDR0, CALLER_ADDR1); > } Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-rt-user= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html