From: "Jakub Kiciński" <moorray3@wp.pl>
To: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Cc: <linux-serial@vger.kernel.org>, Josh Cartwright <joshc@ni.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-rt-users@vger.kernel.org>,
Jon Ringle <jringle@gridpoint.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling
Date: Mon, 14 Mar 2016 23:13:29 +0000 [thread overview]
Message-ID: <20160314231329.1c3a2978@laptop> (raw)
In-Reply-To: <1457692476-19082-1-git-send-email-sean.nyekjaer@prevas.dk>
On Fri, 11 Mar 2016 11:34:36 +0100, Sean Nyekjaer wrote:
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
> ---
> This patch depends on patch "sc16is7xx: drop bogus use of IRQF_ONESHOT"
>
> drivers/tty/serial/sc16is7xx.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 73d46e2..96d1f3e 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -706,13 +706,20 @@ static void sc16is7xx_ist(struct kthread_work *ws)
> struct sc16is7xx_port *s = to_sc16is7xx_port(ws, irq_work);
> int i;
>
> - for (i = 0; i < s->devtype->nr_uart; ++i)
> + for (i = 0; i < s->devtype->nr_uart; ++i) {
> sc16is7xx_port_irq(s, i);
> + enable_irq(s->p[i].port.irq);
> + }
> +
> }
Apart from needless multiple disable/enable (as tglx commented)
I think you also have to re-read the IRQ status (i.e. call
sc16is7xx_port_irq()) because IRQs coming between status read and
enable_irq may get lost for some IRQ controllers.
next prev parent reply other threads:[~2016-03-14 23:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 10:34 [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling Sean Nyekjaer
2016-03-11 10:36 ` Sean Nyekjær
2016-03-11 11:21 ` Sebastian Andrzej Siewior
2016-03-11 11:29 ` Sean Nyekjær
2016-03-11 11:33 ` Sean Nyekjær
2016-03-11 16:43 ` Greg Kroah-Hartman
2016-03-13 10:25 ` Thomas Gleixner
2016-03-14 6:21 ` Sean Nyekjær
2016-03-14 8:48 ` Thomas Gleixner
2016-03-14 23:13 ` Jakub Kiciński [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-03-13 19:05 Maarten Brock
2016-03-14 6:17 ` Sean Nyekjær
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160314231329.1c3a2978@laptop \
--to=moorray3@wp.pl \
--cc=gregkh@linuxfoundation.org \
--cc=joshc@ni.com \
--cc=jringle@gridpoint.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sean.nyekjaer@prevas.dk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).