From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Josh Cartwright <joshc@ni.com>
Cc: linux-rt-users@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>
Subject: Re: [PATCH] list_bl: fixup bogus lockdep warning
Date: Fri, 1 Apr 2016 12:49:46 +0200 [thread overview]
Message-ID: <20160401104946.GD29603@linutronix.de> (raw)
In-Reply-To: <1459400665-12546-1-git-send-email-joshc@ni.com>
* Josh Cartwright | 2016-03-31 00:04:25 [-0500]:
>diff --git a/include/linux/list_bl.h b/include/linux/list_bl.h
>index 44f0b55..a1bfb3b 100644
>--- a/include/linux/list_bl.h
>+++ b/include/linux/list_bl.h
>@@ -42,13 +42,16 @@ struct hlist_bl_node {
> struct hlist_bl_node *next, **pprev;
> };
>
>-static inline void INIT_HLIST_BL_HEAD(struct hlist_bl_head *h)
>-{
>- h->first = NULL;
> #ifdef CONFIG_PREEMPT_RT_BASE
>- raw_spin_lock_init(&h->lock);
>+#define INIT_HLIST_BL_HEAD(h) \
>+do { \
>+ (h)->first = NULL; \
>+ raw_spin_lock_init(&(h)->lock); \
>+} while (0)
>+#else
>+#define INIT_HLIST_BL_HEAD(h) \
>+ (h)->first = NULL; \
I switched the else part to
#define INIT_HLIST_BL_HEAD(h) (h)->first = NULL
> #endif
>-}
Sebastian
next prev parent reply other threads:[~2016-04-01 10:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 21:00 [4.4.4-rt11] Possiblie recursive locking detected in kswapd / mb_cache_shrink_scan() Luis Claudio R. Goncalves
2016-03-19 8:33 ` Thomas Gleixner
2016-03-21 13:34 ` Luis Claudio R. Goncalves
2016-03-21 14:40 ` Josh Cartwright
2016-03-21 20:47 ` Luis Claudio R. Goncalves
2016-03-29 15:04 ` Sebastian Andrzej Siewior
2016-03-29 18:20 ` Josh Cartwright
2016-03-29 23:14 ` Josh Cartwright
2016-03-30 8:16 ` Sebastian Andrzej Siewior
2016-03-31 5:04 ` [PATCH] list_bl: fixup bogus lockdep warning Josh Cartwright
2016-04-01 10:46 ` Sebastian Andrzej Siewior
2016-04-01 10:49 ` Sebastian Andrzej Siewior [this message]
2016-04-01 17:02 ` Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160401104946.GD29603@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=joshc@ni.com \
--cc=lclaudio@uudg.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).