Re: [PATCH] rt-tests: Update the cyclictest man page

[Clark Williams <williams@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1403 bytes --]

On Mon, 25 Apr 2016 16:17:11 +0200 (CEST)
John Kacur <jkacur@redhat.com> wrote:

> From 7e007ac70a83f62583d25b10ad2df0430306bf32 Mon Sep 17 00:00:00 2001
> From: John Kacur <jkacur@redhat.com>
> Date: Mon, 25 Apr 2016 16:08:28 +0200
> Subject: [PATCH] rt-tests: Update the cyclictest man page
> 
> We have done a good job keeping cyclictest help up-to-date, but we have
> not been actively updating the man page.
> 
> There were many missing options, as well as options that don't exist
> anymore. To be more precise, some short form options had been removed,
> but there are still corresponding long-version options.
> 
> This patch contains a considerable amount of updates to the man-page to
> keep it in sync, and in some cases it also updates the cyclictest help
> where needed. For example, the cyclictest help options were not always
> in the proper order. In some cases I changed the wording to make it more
> closely correspond to the man page
> 
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  src/cyclictest/cyclictest.8 | 169 ++++++++++++++++++++++++--------------------
>  src/cyclictest/cyclictest.c |  35 ++++-----
>  2 files changed, 110 insertions(+), 94 deletions(-)

Looks good to me John. I did see one spelling issue:

> +Sned break trace command when latency > USEC

Thanks for cleaning the man page up. I'm afraid I neglected it.

Clark

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]