From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH RT 08/14] kernel/printk: Dont try to print from IRQ/NMI region
Date: Tue, 12 Jul 2016 12:48:07 -0400 [thread overview]
Message-ID: <20160712164818.823747688@goodmis.org> (raw)
In-Reply-To: 20160712164759.154249453@goodmis.org
[-- Attachment #1: 0008-kernel-printk-Don-t-try-to-print-from-IRQ-NMI-region.patch --]
[-- Type: text/plain, Size: 1409 bytes --]
3.14.72-rt76-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
On -RT we try to acquire sleeping locks which might lead to warnings
from lockdep or a warn_on() from spin_try_lock() (which is a rtmutex on
RT).
We don't print in general from a IRQ off region so we should not try
this via console_unblank() / bust_spinlocks() as well.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/printk/printk.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 0b47939efd62..4472339e2156 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -1289,6 +1289,11 @@ static void call_console_drivers(int level, const char *text, size_t len)
if (!console_drivers)
return;
+ if (IS_ENABLED(CONFIG_PREEMPT_RT_BASE)) {
+ if (in_irq() || in_nmi())
+ return;
+ }
+
migrate_disable();
for_each_console(con) {
if (exclusive_console && con != exclusive_console)
@@ -2214,6 +2219,11 @@ void console_unblank(void)
{
struct console *c;
+ if (IS_ENABLED(CONFIG_PREEMPT_RT_BASE)) {
+ if (in_irq() || in_nmi())
+ return;
+ }
+
/*
* console_unblank can no longer be called in interrupt context unless
* oops_in_progress is set to 1..
--
2.8.1
next prev parent reply other threads:[~2016-07-12 16:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 16:47 [PATCH RT 00/14] Linux 3.14.72-rt76-rc1 Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 01/14] kvm, rt: change async pagefault code locking for PREEMPT_RT Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 02/14] mm/zsmalloc: Use get/put_cpu_light in zs_map_object()/zs_unmap_object() Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 03/14] net: dev: always take qdiscs busylock in __dev_xmit_skb() Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 04/14] list_bl: fixup bogus lockdep warning Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 05/14] ARM: imx: always use TWD on IMX6Q Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 06/14] perf/x86/intel/rapl: Make PMU lock raw Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 07/14] sched,preempt: Fix preempt_count manipulations Steven Rostedt
2016-07-12 16:48 ` Steven Rostedt [this message]
2016-07-12 16:48 ` [PATCH RT 09/14] arm: lazy preempt: correct resched condition Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 10/14] locallock: add local_lock_on() Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 11/14] mm: perform lru_add_drain_all() remotely Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 12/14] trace: correct off by one while recording the trace-event Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 13/14] x86: Fix an RT MCE crash Steven Rostedt
2016-07-12 16:48 ` [PATCH RT 14/14] Linux 3.14.72-rt76-rc1 Steven Rostedt
2016-07-12 23:21 ` Linux 3.14.72-rt76-rc2 Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712164818.823747688@goodmis.org \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).