From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH RT 6/7] fs/dcache: incremental fixup of the retry routine
Date: Fri, 23 Sep 2016 15:50:14 -0400 [thread overview]
Message-ID: <20160923195020.208313106@goodmis.org> (raw)
In-Reply-To: 20160923195008.543008518@goodmis.org
[-- Attachment #1: 0006-fs-dcache-incremental-fixup-of-the-retry-routine.patch --]
[-- Type: text/plain, Size: 1199 bytes --]
3.2.82-rt119-rc1 stable review patch.
If anyone has any objections, please let me know.
------------------
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
It has been pointed out by tglx that on UP the non-RT task could spin
its entire time slice because the lock owner is preempted. This won't
happen on !RT. So we back to "chill" if we can't cond_resched() did not
work.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
fs/dcache.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index bd9bd649c390..bea5589bc957 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -38,8 +38,6 @@
#include <linux/prefetch.h>
#include <linux/ratelimit.h>
#include <linux/delay.h>
-#include <linux/sched/rt.h>
-#include <linux/sched/deadline.h>
#include "internal.h"
/*
@@ -513,10 +511,11 @@ kill_it:
if (parent == dentry) {
/* the task with the highest priority won't schedule */
r = cond_resched();
- if (!r && (rt_task(current) || dl_task(current)))
+ if (!r)
cpu_chill();
- } else
+ } else {
dentry = parent;
+ }
goto repeat;
}
}
--
2.8.1
next prev parent reply other threads:[~2016-09-23 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 19:50 [PATCH RT 0/7] Linux 3.2.82-rt119-rc1 Steven Rostedt
2016-09-23 19:50 ` [PATCH RT 1/7] timers: wakeup all timer waiters Steven Rostedt
2016-09-23 19:50 ` [PATCH RT 2/7] timers: wakeup all timer waiters without holding the base lock Steven Rostedt
2016-09-23 19:50 ` [PATCH RT 4/7] net: add a lock around icmp_sk() Steven Rostedt
2016-09-23 19:50 ` [PATCH RT 5/7] fs/dcache: resched/chill only if we make no progress Steven Rostedt
2016-09-23 19:50 ` Steven Rostedt [this message]
2016-09-23 19:50 ` [PATCH RT 7/7] Linux 3.2.82-rt119-rc1 Steven Rostedt
[not found] ` <20160923195019.349112022@goodmis.org>
2016-09-23 19:58 ` [PATCH RT 3/7] net: add back the missing serialization in ip_send_unicast_reply() Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2016-09-23 16:48 [PATCH RT 0/7] Linux 3.4.112-rt144-rc1 Steven Rostedt
2016-09-23 16:48 ` [PATCH RT 6/7] fs/dcache: incremental fixup of the retry routine Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923195020.208313106@goodmis.org \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).