From: David Miller <davem@davemloft.net>
To: efault@gmx.de
Cc: netdev@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: kernel (master) build failure w. !CONFIG_NET_RX_BUSY_POLL
Date: Thu, 29 Jun 2017 15:35:27 -0400 (EDT) [thread overview]
Message-ID: <20170629.153527.1327069677943074079.davem@davemloft.net> (raw)
In-Reply-To: <1498636860.5505.28.camel@gmx.de>
From: Mike Galbraith <efault@gmx.de>
Date: Wed, 28 Jun 2017 10:01:00 +0200
> Greetings network wizards,
>
> The latest RT explicitly disables CONFIG_NET_RX_BUSY_POLL, thus
> uncovering $subject. Below is what I did about it.
>
> -Mike
>
> net: Move napi_hash_add/del() inside CONFIG_NET_RX_BUSY_POLL
>
> Since 545cd5e5ec54 ("net: Busy polling should ignore sender CPUs"),
> kernel build fails when CONFIG_NET_RX_BUSY_POLL is disabled. Move
> napi_hash_add/del() accordingly.
>
> Banged-upon-by: Mike Galbraith <efault@gmx.de>
First, this is in no way a standard signoff or ack tag.
Second, you must provide the complete set of build failure details
so that anyone just reading your posting can understand and fully
review your patch without having to go anywhere else for the
pertinent information.
And, lastly, I can't see how anything like this could be necessary
with the way the code is currently structures in the 'net' tree. This
is really why you need to make a full report, with build failure
messages, as well as an explanation of what your change does, and why
it does it that way.
Thanks.
next prev parent reply other threads:[~2017-06-29 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 8:01 kernel (master) build failure w. !CONFIG_NET_RX_BUSY_POLL Mike Galbraith
2017-06-29 19:35 ` David Miller [this message]
2017-06-30 2:18 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629.153527.1327069677943074079.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=efault@gmx.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).