From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaldo Carvalho de Melo Subject: Re: [RFC+PATCH] Infiniband hfi1 + PREEMPT_RT_FULL issues Date: Tue, 26 Sep 2017 10:15:29 -0300 Message-ID: <20170926131529.GB25735@kernel.org> References: <20170925144949.GP29668@kernel.org> <20170925161528.52d34769@vmware.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Mike Marciniszyn , Dennis Dalessandro , Thomas Gleixner , Clark Williams , Dean Luick , Doug Ledford , Jubin John , Kaike Wan , Leon Romanovsky , Peter Zijlstra , Sebastian Andrzej Siewior , Sebastian Sanchez , linux-rt-users-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steven Rostedt Return-path: Content-Disposition: inline In-Reply-To: <20170925161528.52d34769-ZM9ACYiE99GSuEeoRQArULNAH6kLmebB@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rt-users.vger.kernel.org Em Mon, Sep 25, 2017 at 04:15:28PM -0400, Steven Rostedt escreveu: > On Mon, 25 Sep 2017 11:49:49 -0300 Arnaldo Carvalho de Melo wrote: > > I'm wondering if turning this sc->alloc_lock to a raw_spin_lock is the > > right solution, which I'm afraid its not, as there are places where it > > is held and then the code goes on to grab other non-raw spinlocks... > No, the correct solution is to convert the preempt_disable into a > local_lock(), which will be a preempt_disable when PREEMPT_RT is not > set. Look for other patches that convert preempt_disable() into > local_lock()s for examples. Thanks, I had seen a patch patch by Sebastian for random.c doing that, will continue in that direction. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html