Re: [PATCH 09/18] tracing: Add indexing of arguments for function based events

Namhyung Kim
2018-02-08T23:56:15Z

On Thu, Feb 08, 2018 at 10:43:43AM -0500, Steven Rostedt wrote:
> On Thu, 8 Feb 2018 19:59:24 +0900
> Namhyung Kim <namhyung@kernel.org> wrote:
>
> > > @@ -347,6 +361,8 @@ static long long get_arg(struct func_arg *arg, unsigned long val)
> > > char buf[8];
> > > int ret;
> > >
> > > + val += arg->index;
> > > +
> > > if (!arg->indirect)
> > > return val;
> >
> > So this also works without the indirect, and just add the immediate to
> > the value.
>
> Not sure what you are asking here. The immediate adds to the current
> value, where as the indirect will then look what's at that location.

I expected that the immediate offset is only meaningful with the
indirect (dereference) as the doc says just about it. So I asked it
was intentional or not.

Thanks,
Namhyung