From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mike Galbraith <efault@gmx.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [missing 4.16-rt5 patch ?] mm/memcontrol: Don't call schedule_work_on in preemption disabled context
Date: Mon, 11 Jun 2018 17:29:40 +0200 [thread overview]
Message-ID: <20180611152940.ul5xunrepa5ine4s@linutronix.de> (raw)
In-Reply-To: <1528606772.13494.14.camel@gmx.de>
On 2018-06-10 06:59:32 [+0200], Mike Galbraith wrote:
> Was dropping this patch unintentional?
>
> (met the gripe in my tip-rt5 tree, so resurrected it)
Not sure. I remember the local_irq_save() block was dealing with
counters only and it was safe to drop it.
The schedule_work_on() part is obvious (not to mention the possible
latency part).
So that css_put() is not a problem? I'm mostly curious in the callback
which would run irq-off section. How does not get into that code path
anyway, is there something in the LTP that would trigger that?
Sebastian
next prev parent reply other threads:[~2018-06-11 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 16:42 [ANNOUNCE] v4.16.12-rt5 Sebastian Andrzej Siewior
2018-06-10 4:59 ` [missing 4.16-rt5 patch ?] mm/memcontrol: Don't call schedule_work_on in preemption disabled context Mike Galbraith
2018-06-11 15:29 ` Sebastian Andrzej Siewior [this message]
2018-06-11 15:55 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611152940.ul5xunrepa5ine4s@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).