From: Steven Rostedt <rostedt@goodmis.org>
To: Mike Galbraith <efault@gmx.de>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [rfc 4.16-rt patch] arm64: efi,fpsimd: use a local_lock() in efi_virtmap_load()
Date: Wed, 11 Jul 2018 21:08:55 -0400 [thread overview]
Message-ID: <20180711210855.53f31874@vmware.local.home> (raw)
In-Reply-To: <1531321642.12761.30.camel@gmx.de>
On Wed, 11 Jul 2018 17:07:22 +0200
Mike Galbraith <efault@gmx.de> wrote:
> --- a/arch/arm64/kernel/fpsimd.c
> +++ b/arch/arm64/kernel/fpsimd.c
> @@ -607,8 +607,8 @@ int sve_set_vector_length(struct task_st
> sve_to_fpsimd(task);
>
> if (task == current) {
> - local_unlock(fpsimd_lock);
> local_bh_enable();
> + local_unlock(fpsimd_lock);
> }
>
> /*
> @@ -841,8 +841,8 @@ asmlinkage void do_sve_acc(unsigned int
>
> sve_alloc(current);
>
> - local_bh_disable();
> local_lock(fpsimd_lock);
> + local_bh_disable();
>
> task_fpsimd_save();
> fpsimd_to_sve(current);
> @@ -854,8 +854,8 @@ asmlinkage void do_sve_acc(unsigned int
> if (test_and_set_thread_flag(TIF_SVE))
> WARN_ON(1); /* SVE access shouldn't have trapped */
>
> - local_unlock(fpsimd_lock);
> local_bh_enable();
> + local_unlock(fpsimd_lock);
> }
>
We really need to have a local_lock_bh(...)
-- Steve
next prev parent reply other threads:[~2018-07-12 1:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 15:07 [rfc 4.16-rt patch] arm64: efi,fpsimd: use a local_lock() in efi_virtmap_load() Mike Galbraith
2018-07-12 1:08 ` Steven Rostedt [this message]
2018-07-26 15:09 ` Sebastian Andrzej Siewior
2018-07-26 17:52 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711210855.53f31874@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=efault@gmx.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).