* stable-rt: broken vmbus_drv.c
@ 2018-08-29 14:28 Ralf Ramsauer
2018-08-29 16:12 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Ramsauer @ 2018-08-29 14:28 UTC (permalink / raw)
To: linux-rt-users, Steven Rostedt; +Cc: Thomas Gleixner
Hi,
latest stable 4.14.63-rt40 fails with CONFIG_HYPERV:
drivers/hv/vmbus_drv.c: In function ‘vmbus_isr’:
drivers/hv/vmbus_drv.c:969:25: error: implicit declaration of function
‘get_irq_regs’; did you mean ‘get_mm_rss’?
[-Werror=implicit-function-declaration]
struct pt_regs *regs = get_irq_regs();
^~~~~~~~~~~~
get_mm_rss
drivers/hv/vmbus_drv.c:969:25: warning: initialization of ‘struct
pt_regs *’ from ‘int’ makes pointer from integer without a cast
[-Wint-conversion]
Thomas' 5bef95248a270f68a1e448337b1d4c927cf8b0b2 in stable-rt ("random:
Make it work on rt") seems to break it. 4.14.59-rt37 compiles fine, so I
guess the include chain somehow changed upstream.
Simple fix below, include irq_regs.h.
Ralf
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index cedf225d4182..185647915077 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -38,6 +38,7 @@
#include <asm/hyperv.h>
#include <asm/hypervisor.h>
+#include <asm/irq_regs.h>
#include <asm/mshyperv.h>
#include <linux/notifier.h>
#include <linux/ptrace.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: stable-rt: broken vmbus_drv.c
2018-08-29 14:28 stable-rt: broken vmbus_drv.c Ralf Ramsauer
@ 2018-08-29 16:12 ` Sebastian Andrzej Siewior
2018-08-29 16:19 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2018-08-29 16:12 UTC (permalink / raw)
To: Ralf Ramsauer; +Cc: linux-rt-users, Steven Rostedt, Thomas Gleixner
On 2018-08-29 16:28:14 [+0200], Ralf Ramsauer wrote:
> Hi,
Hi Ralf,
> latest stable 4.14.63-rt40 fails with CONFIG_HYPERV:
seems to be taken care:
https://lkml.kernel.org/r/20180827224121.2dc55b30@vmware.local.home
Sebastian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: stable-rt: broken vmbus_drv.c
2018-08-29 16:12 ` Sebastian Andrzej Siewior
@ 2018-08-29 16:19 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2018-08-29 16:19 UTC (permalink / raw)
To: Sebastian Andrzej Siewior; +Cc: Ralf Ramsauer, linux-rt-users, Thomas Gleixner
On Wed, 29 Aug 2018 18:12:17 +0200
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> On 2018-08-29 16:28:14 [+0200], Ralf Ramsauer wrote:
> > Hi,
> Hi Ralf,
>
> > latest stable 4.14.63-rt40 fails with CONFIG_HYPERV:
>
> seems to be taken care:
> https://lkml.kernel.org/r/20180827224121.2dc55b30@vmware.local.home
>
> Sebastian
I was just in the process of replying too. Anyway, I'll be adding this
later this week or early next week.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-29 20:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-29 14:28 stable-rt: broken vmbus_drv.c Ralf Ramsauer
2018-08-29 16:12 ` Sebastian Andrzej Siewior
2018-08-29 16:19 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).