From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claudio Scordino Subject: Re: [PATCH] kernel/time/posix-cpu-timers: Remove useless call to check_dl_overrun Date: Thu, 8 Nov 2018 11:58:08 +0100 Message-ID: <20181108105808.GB13282@erbrow> References: <20181107111032.32291-1-juri.lelli@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, bristot@redhat.com, linux-rt-users@vger.kernel.org, mtk.manpages@gmail.com, Mathieu Poirier To: Juri Lelli Return-path: Content-Disposition: inline In-Reply-To: <20181107111032.32291-1-juri.lelli@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-rt-users.vger.kernel.org On 071118, 12:10, Juri Lelli wrote: > check_dl_overrun is used to send a SIGXCPU to users that asked to be > informed when SCHED_DEADLINE runtime overruns occur. > > The function is called by check_thread_timers already, so the call in > check_process_timers is redundant/wrong (even though harmless). > > Remove it. > > Fixes: 34be39305a77 ("sched/deadline: Implement "runtime overrun signal" support") > Signed-off-by: Juri Lelli > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Luca Abeni > Cc: Claudio Scordino > Cc: Mathieu Poirier > --- > kernel/time/posix-cpu-timers.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c > index ce32cf741b25..8f0644af40be 100644 > --- a/kernel/time/posix-cpu-timers.c > +++ b/kernel/time/posix-cpu-timers.c > @@ -917,9 +917,6 @@ static void check_process_timers(struct task_struct *tsk, > struct task_cputime cputime; > unsigned long soft; > > - if (dl_task(tsk)) > - check_dl_overrun(tsk); > - > /* > * If cputimer is not running, then there are no active > * process wide timers (POSIX 1.b, itimers, RLIMIT_CPU). > -- [ Superfluous as (fortunately) already queued...] Tested-by: Claudio Scordino Thank you for taking care of this pending issue. Claudio