From: Masami Hiramatsu <mhiramat@kernel.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: rostedt@goodmis.org, tglx@linutronix.de, mhiramat@kernel.org,
namhyung@kernel.org, vedang.patel@intel.com,
bigeasy@linutronix.de, joel@joelfernandes.org,
mathieu.desnoyers@efficios.com, julia@ni.com,
linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v15 14/15] tracing: Add alternative synthetic event trace action test case
Date: Sat, 16 Feb 2019 00:06:17 +0900 [thread overview]
Message-ID: <20190216000617.2b3e80357f0bef490cfe6c83@kernel.org> (raw)
In-Reply-To: <0616d18423ab1dfdbf333bce9c92ac4fa0779207.1550100284.git.tom.zanussi@linux.intel.com>
Hi Tom,
On Wed, 13 Feb 2019 17:42:54 -0600
Tom Zanussi <zanussi@kernel.org> wrote:
> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>
> Add a test case for the alternative trace(<synthetic_event, params)
> synthetic event generation syntax.
>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
This looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
> ---
> .../inter-event/trigger-trace-action-hist.tc | 42 ++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc
> new file mode 100644
> index 000000000000..8021d60aafec
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-trace-action-hist.tc
> @@ -0,0 +1,42 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# description: event trigger - test inter-event histogram trigger trace action
> +
> +fail() { #msg
> + echo $1
> + exit_fail
> +}
> +
> +if [ ! -f set_event ]; then
> + echo "event tracing is not supported"
> + exit_unsupported
> +fi
> +
> +if [ ! -f synthetic_events ]; then
> + echo "synthetic event is not supported"
> + exit_unsupported
> +fi
> +
> +grep -q "trace(<synthetic_event>" README || exit_unsupported # version issue
> +
> +echo "Test create synthetic event"
> +
> +echo 'wakeup_latency u64 lat pid_t pid char comm[16]' > synthetic_events
> +if [ ! -d events/synthetic/wakeup_latency ]; then
> + fail "Failed to create wakeup_latency synthetic event"
> +fi
> +
> +echo "Test create histogram for synthetic event using trace action"
> +echo "Test histogram variables,simple expression support and trace action"
> +
> +echo 'hist:keys=pid:ts0=common_timestamp.usecs if comm=="ping"' > events/sched/sched_wakeup/trigger
> +echo 'hist:keys=next_pid:wakeup_lat=common_timestamp.usecs-$ts0:onmatch(sched.sched_wakeup).trace(wakeup_latency,$wakeup_lat,next_pid,next_comm) if next_comm=="ping"' > events/sched/sched_switch/trigger
> +echo 'hist:keys=comm,pid,lat:wakeup_lat=lat:sort=lat' > events/synthetic/wakeup_latency/trigger
> +
> +ping $LOCALHOST -c 5
> +
> +if ! grep -q "ping" events/synthetic/wakeup_latency/hist; then
> + fail "Failed to create trace action inter-event histogram"
> +fi
> +
> +exit 0
> --
> 2.14.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2019-02-15 15:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 23:42 [PATCH v15 00/15] tracing: Hist trigger snapshot and onchange additions Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 01/15] tracing: Refactor hist trigger action code Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 02/15] tracing: Make hist trigger Documentation better reflect actions/handlers Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 03/15] tracing: Split up onmatch action data Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 04/15] tracing: Generalize hist trigger onmax and save action Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 05/15] tracing: Add conditional snapshot Tom Zanussi
2019-02-14 23:11 ` Steven Rostedt
2019-02-14 23:25 ` Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 06/15] tracing: Add hist trigger snapshot() action Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 07/15] tracing: Add hist trigger snapshot() action Documentation Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 08/15] tracing: Add hist trigger onchange() handler Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 09/15] tracing: Add hist trigger onchange() handler Documentation Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 10/15] tracing: Add alternative synthetic event trace action syntax Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 11/15] tracing: Add SPDX license GPL-2.0 license identifier to inter-event testcases Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 12/15] tracing: Add hist trigger snapshot() action test case Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 13/15] tracing: Add hist trigger onchange() handler " Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 14/15] tracing: Add alternative synthetic event trace action " Tom Zanussi
2019-02-15 15:06 ` Masami Hiramatsu [this message]
2019-02-13 23:42 ` [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' " Tom Zanussi
2019-02-15 15:08 ` Masami Hiramatsu
2019-02-15 15:36 ` Steven Rostedt
2019-02-20 17:17 ` Steven Rostedt
2019-02-20 17:38 ` Tom Zanussi
2019-02-20 17:56 ` Steven Rostedt
2019-02-20 18:10 ` Tom Zanussi
2019-02-20 18:33 ` Steven Rostedt
2019-02-20 18:45 ` Tom Zanussi
2019-02-20 18:54 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190216000617.2b3e80357f0bef490cfe6c83@kernel.org \
--to=mhiramat@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vedang.patel@intel.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).