From: Steven Rostedt <rostedt@goodmis.org>
To: Tom Zanussi <zanussi@kernel.org>
Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org,
vedang.patel@intel.com, bigeasy@linutronix.de,
joel@joelfernandes.org, mathieu.desnoyers@efficios.com,
julia@ni.com, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case
Date: Wed, 20 Feb 2019 12:17:48 -0500 [thread overview]
Message-ID: <20190220121748.7aa83459@gandalf.local.home> (raw)
In-Reply-To: <1790bf93e01dbdfa1b4af945f42147d92bd565aa.1550100284.git.tom.zanussi@linux.intel.com>
On Wed, 13 Feb 2019 17:42:55 -0600
Tom Zanussi <zanussi@kernel.org> wrote:
> From: Tom Zanussi <tom.zanussi@linux.intel.com>
>
> Add a test case verifying that basic action combinations fail as
> expected.
>
Hi Tom,
This test appears to fail:
# echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger
-bash: echo: write error: Invalid argument
# cat /sys/kernel/debug/tracing/events/sched/sched_waking/hist
ERROR: action parsing: Handler doesn't support action: save
Last command: keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)
Is the "save" feature implemented here? It's in the README too. Should
it be removed?
-- Steve
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
> .../inter-event/trigger-action-hist-xfail.tc | 30 ++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc
>
> diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc
> new file mode 100644
> index 000000000000..1221240f8cf6
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-action-hist-xfail.tc
> @@ -0,0 +1,30 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# description: event trigger - test inter-event histogram trigger expected fail actions
> +
> +fail() { #msg
> + echo $1
> + exit_fail
> +}
> +
> +if [ ! -f set_event ]; then
> + echo "event tracing is not supported"
> + exit_unsupported
> +fi
> +
> +if [ ! -f snapshot ]; then
> + echo "snapshot is not supported"
> + exit_unsupported
> +fi
> +
> +grep -q "snapshot()" README || exit_unsupported # version issue
> +
> +echo "Test expected snapshot action failure"
> +
> +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).snapshot()' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && exit_fail
> +
> +echo "Test expected save action failure"
> +
> +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && exit_fail
> +
> +exit_xfail
next prev parent reply other threads:[~2019-02-20 17:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 23:42 [PATCH v15 00/15] tracing: Hist trigger snapshot and onchange additions Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 01/15] tracing: Refactor hist trigger action code Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 02/15] tracing: Make hist trigger Documentation better reflect actions/handlers Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 03/15] tracing: Split up onmatch action data Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 04/15] tracing: Generalize hist trigger onmax and save action Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 05/15] tracing: Add conditional snapshot Tom Zanussi
2019-02-14 23:11 ` Steven Rostedt
2019-02-14 23:25 ` Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 06/15] tracing: Add hist trigger snapshot() action Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 07/15] tracing: Add hist trigger snapshot() action Documentation Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 08/15] tracing: Add hist trigger onchange() handler Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 09/15] tracing: Add hist trigger onchange() handler Documentation Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 10/15] tracing: Add alternative synthetic event trace action syntax Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 11/15] tracing: Add SPDX license GPL-2.0 license identifier to inter-event testcases Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 12/15] tracing: Add hist trigger snapshot() action test case Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 13/15] tracing: Add hist trigger onchange() handler " Tom Zanussi
2019-02-13 23:42 ` [PATCH v15 14/15] tracing: Add alternative synthetic event trace action " Tom Zanussi
2019-02-15 15:06 ` Masami Hiramatsu
2019-02-13 23:42 ` [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' " Tom Zanussi
2019-02-15 15:08 ` Masami Hiramatsu
2019-02-15 15:36 ` Steven Rostedt
2019-02-20 17:17 ` Steven Rostedt [this message]
2019-02-20 17:38 ` Tom Zanussi
2019-02-20 17:56 ` Steven Rostedt
2019-02-20 18:10 ` Tom Zanussi
2019-02-20 18:33 ` Steven Rostedt
2019-02-20 18:45 ` Tom Zanussi
2019-02-20 18:54 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220121748.7aa83459@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=vedang.patel@intel.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).