From: Christoph Hellwig <hch@infradead.org>
To: Julien Grall <julien.grall@arm.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
logang@deltatee.com, douliyangs@gmail.com,
miquel.raynal@bootlin.com, marc.zyngier@arm.com,
jason@lakedaemon.net, tglx@linutronix.de, joro@8bytes.org,
robin.murphy@arm.com, bigeasy@linutronix.de,
linux-rt-users@vger.kernel.org
Subject: Re: [PATCH 2/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg in two parts
Date: Tue, 23 Apr 2019 00:08:23 -0700 [thread overview]
Message-ID: <20190423070823.GA12114@infradead.org> (raw)
In-Reply-To: <20190418172611.21561-3-julien.grall@arm.com>
On Thu, Apr 18, 2019 at 06:26:06PM +0100, Julien Grall wrote:
> +int iommu_dma_prepare_msi(struct msi_desc *desc, phys_addr_t msi_addr)
> {
> + struct device *dev = msi_desc_to_dev(desc);
> struct iommu_domain *domain = iommu_get_domain_for_dev(dev);
> struct iommu_dma_cookie *cookie;
> unsigned long flags;
>
> + if (!domain || !domain->iova_cookie) {
> + desc->iommu_cookie = NULL;
> + return 0;
> + }
>
> cookie = domain->iova_cookie;
>
> @@ -908,10 +908,33 @@ void iommu_dma_map_msi_msg(int irq, struct msi_msg *msg)
> * of an MSI from within an IPI handler.
> */
> spin_lock_irqsave(&cookie->msi_lock, flags);
> + desc->iommu_cookie = iommu_dma_get_msi_page(dev, msi_addr, domain);
> spin_unlock_irqrestore(&cookie->msi_lock, flags);
>
> + return (desc->iommu_cookie) ? 0 : -ENOMEM;
No need for the braces. Also I personally find a:
if (!desc->iommu_cookie)
return -ENOMEM;
return 0;
much more readable, but that might just be personal preference.
next prev parent reply other threads:[~2019-04-23 7:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 17:26 [PATCH 0/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg in two parts Julien Grall
2019-04-18 17:26 ` [PATCH 1/7] genirq/msi: Add a new field in msi_desc to store an IOMMU cookie Julien Grall
2019-04-18 19:28 ` Thomas Gleixner
2019-04-23 9:26 ` Julien Grall
2019-04-23 10:23 ` Marc Zyngier
2019-04-23 10:51 ` Julien Grall
2019-04-23 11:46 ` Marc Zyngier
2019-04-23 13:19 ` Robin Murphy
2019-04-23 13:42 ` Marc Zyngier
2019-04-18 17:26 ` [PATCH 2/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg in two parts Julien Grall
2019-04-23 7:08 ` Christoph Hellwig [this message]
2019-04-23 10:55 ` Julien Grall
2019-04-23 10:54 ` Marc Zyngier
2019-04-29 13:14 ` Julien Grall
2019-04-18 17:26 ` [PATCH 3/7] irqchip/gicv2m: Don't map the MSI page in gicv2m_compose_msi_msg Julien Grall
2019-04-18 17:26 ` [PATCH 4/7] irqchip/gic-v3-its: Don't map the MSI page in its_irq_compose_msi_msg Julien Grall
2019-04-18 17:26 ` [PATCH 5/7] irqchip/ls-scfg-msi: Don't map the MSI page in ls_scfg_msi_compose_msg Julien Grall
2019-04-18 17:26 ` [PATCH 6/7] irqchip/gic-v3-mbi: Don't map the MSI page in mbi_compose_m{b, s}i_msg Julien Grall
2019-04-18 17:26 ` [PATCH 7/7] iommu/dma-iommu: Remove iommu_dma_map_msi_msg() Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423070823.GA12114@infradead.org \
--to=hch@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=douliyangs@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=joro@8bytes.org \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=marc.zyngier@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox